Skip to content

Commit bb1a930

Browse files
committed
Fixup unit tests
1 parent 79ca218 commit bb1a930

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

tst/IceFunctionalityTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ TEST_F(IceFunctionalityTest, IceAgentIceAgentAddIceServerUnitTest)
305305
EXPECT_EQ(STATUS_SUCCESS, parseIceServer(&iceServer, (PCHAR) "turn:54.202.170.151:443?transport=udp", (PCHAR) "username", (PCHAR) "password"));
306306
EXPECT_TRUE(!iceServer.isSecure);
307307
EXPECT_EQ(iceServer.transport, KVS_SOCKET_PROTOCOL_UDP);
308-
EXPECT_EQ(443, (UINT16) getInt16(iceServer.ipAddress.port));
308+
EXPECT_EQ(443, (UINT16) getInt16(iceServer.ipAddresses.ipv4Address.port));
309309

310310
/* we are not doing full validation. Only parsing out what we know */
311311
EXPECT_EQ(STATUS_SUCCESS, parseIceServer(&iceServer, (PCHAR) "turn:54.202.170.151:443?randomstuff", (PCHAR) "username", (PCHAR) "password"));

tst/NetworkApiTest.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ class NetworkApiTest : public WebRtcClientTestBase {
1111

1212
TEST_F(NetworkApiTest, GetIpWithHostNameTest)
1313
{
14-
KvsIpAddress ipAddress;
15-
EXPECT_EQ(STATUS_NULL_ARG, getIpWithHostName(NULL, &ipAddress));
16-
EXPECT_EQ(STATUS_RESOLVE_HOSTNAME_FAILED, getIpWithHostName((PCHAR) "stun:stun.test.net:3478", &ipAddress));
17-
EXPECT_EQ(STATUS_SUCCESS, getIpWithHostName((PCHAR) "35-90-63-38.t-ae7dd61a.kinesisvideo.us-west-2.amazonaws.com", &ipAddress));
18-
EXPECT_EQ(STATUS_SUCCESS, getIpWithHostName((PCHAR) "12.34.45.40", &ipAddress));
19-
EXPECT_EQ(STATUS_SUCCESS, getIpWithHostName((PCHAR) "2001:0db8:85a3:0000:0000:8a2e:0370:7334", &ipAddress));
20-
EXPECT_EQ(STATUS_RESOLVE_HOSTNAME_FAILED, getIpWithHostName((PCHAR) ".12.34.45.40", &ipAddress));
21-
EXPECT_EQ(STATUS_RESOLVE_HOSTNAME_FAILED, getIpWithHostName((PCHAR) "...........", &ipAddress));
14+
DualKvsIpAddresses ipAddresses;
15+
EXPECT_EQ(STATUS_NULL_ARG, getIpWithHostName(NULL, &ipAddresses));
16+
EXPECT_EQ(STATUS_RESOLVE_HOSTNAME_FAILED, getIpWithHostName((PCHAR) "stun:stun.test.net:3478", &ipAddresses));
17+
EXPECT_EQ(STATUS_SUCCESS, getIpWithHostName((PCHAR) "35-90-63-38.t-ae7dd61a.kinesisvideo.us-west-2.amazonaws.com", &ipAddresses));
18+
EXPECT_EQ(STATUS_SUCCESS, getIpWithHostName((PCHAR) "12.34.45.40", &ipAddresses));
19+
EXPECT_EQ(STATUS_SUCCESS, getIpWithHostName((PCHAR) "2001:0db8:85a3:0000:0000:8a2e:0370:7334", &ipAddresses));
20+
EXPECT_EQ(STATUS_RESOLVE_HOSTNAME_FAILED, getIpWithHostName((PCHAR) ".12.34.45.40", &ipAddresses));
21+
EXPECT_EQ(STATUS_RESOLVE_HOSTNAME_FAILED, getIpWithHostName((PCHAR) "...........", &ipAddresses));
2222
}
2323

2424
TEST_F(NetworkApiTest, ipIpAddrTest)

tst/TurnConnectionFunctionalityTest.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class TurnConnectionFunctionalityTest : public WebRtcClientTestBase {
5252

5353
EXPECT_EQ(STATUS_SUCCESS, getLocalhostIpAddresses(localIpInterfaces, &localIpInterfaceCount, NULL, 0));
5454
for (i = 0; i < localIpInterfaceCount; ++i) {
55-
if (localIpInterfaces[i].family == pTurnServer->ipAddress.family && (pTurnSocketAddr == NULL || localIpInterfaces[i].isPointToPoint)) {
55+
if (localIpInterfaces[i].family == pTurnServer->ipAddresses.ipv4Address.family && (pTurnSocketAddr == NULL || localIpInterfaces[i].isPointToPoint)) {
5656
pTurnSocketAddr = &localIpInterfaces[i];
5757
}
5858
}
@@ -69,8 +69,8 @@ class TurnConnectionFunctionalityTest : public WebRtcClientTestBase {
6969
return STATUS_SUCCESS;
7070
};
7171
EXPECT_EQ(STATUS_SUCCESS,
72-
createSocketConnection((KVS_IP_FAMILY_TYPE) pTurnServer->ipAddress.family, KVS_ICE_DEFAULT_TURN_PROTOCOL, NULL,
73-
&pTurnServer->ipAddress, (UINT64) this, onDataHandler, 0, &pTurnSocket));
72+
createSocketConnection((KVS_IP_FAMILY_TYPE) pTurnServer->ipAddresses.ipv4Address.family, KVS_ICE_DEFAULT_TURN_PROTOCOL, NULL,
73+
&pTurnServer->ipAddresses.ipv4Address, (UINT64) this, onDataHandler, 0, &pTurnSocket));
7474
EXPECT_EQ(STATUS_SUCCESS, connectionListenerAddConnection(pConnectionListener, pTurnSocket));
7575
ASSERT_EQ(STATUS_SUCCESS,
7676
createTurnConnection(pTurnServer, timerQueueHandle, TURN_CONNECTION_DATA_TRANSFER_MODE_DATA_CHANNEL, KVS_ICE_DEFAULT_TURN_PROTOCOL,

0 commit comments

Comments
 (0)