Skip to content

Commit e002aba

Browse files
rsareddy0329Roja Reddy Sareddy
rsareddy0329
and
Roja Reddy Sareddy
authored
Add workflows in master-v3 branch (#1686)
* Test intelligent defaults in sagemaker-core with utils module * Test intelligent defaults in sagemaker-core with utils module * Test intelligent defaults in sagemaker-core with utils module * Test intelligent defaults in sagemaker-core with utils module * Test intelligent defaults in sagemaker-core with utils module * Add serializer and deserializer in Endpoint configuration * Add serializer and deserializer in Endpoint configuration * Add serializer and deserializer in Endpoint configuration * Test Commit * Add workflows for V3 PR checks * Remove dummy commit --------- Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>
1 parent b364cb6 commit e002aba

File tree

6 files changed

+159
-0
lines changed

6 files changed

+159
-0
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
---
2+
name: Bug report
3+
about: File a report to help us reproduce and fix the problem
4+
title: ''
5+
labels: 'bug'
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To reproduce**
14+
A clear, step-by-step set of instructions to reproduce the bug.
15+
The provided code need to be **complete** and **runnable**, if additional data is needed, please include them in the issue.
16+
17+
**Expected behavior**
18+
A clear and concise description of what you expected to happen.
19+
20+
**Screenshots or logs**
21+
If applicable, add screenshots or logs to help explain your problem.
22+
23+
**System information**
24+
A description of your system. Please provide:
25+
- **SageMaker Python SDK version**:
26+
- **Framework name (eg. PyTorch) or algorithm (eg. KMeans)**:
27+
- **Framework version**:
28+
- **Python version**:
29+
- **CPU or GPU**:
30+
- **Custom Docker image (Y/N)**:
31+
32+
**Additional context**
33+
Add any other context about the problem here.

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Ask a question
4+
url: https://github.com/aws/sagemaker-python-sdk/discussions
5+
about: Use GitHub Discussions to ask and answer questions

‎.github/ISSUE_TEMPLATE/documentation-request.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
name: Documentation request
3+
about: Request improved documentation
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**What did you find confusing? Please describe.**
11+
A clear and concise description of what you found confusing. Ex. I tried to [...] but I didn't understand how to [...]
12+
13+
**Describe how documentation can be improved**
14+
A clear and concise description of where documentation was lacking and how it can be improved.
15+
16+
**Additional context**
17+
Add any other context or screenshots about the documentation request here.

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Suggest new functionality for this library
4+
title: ''
5+
labels: 'feature request'
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the feature you'd like**
11+
A clear and concise description of the functionality you want.
12+
13+
**How would this feature be used? Please describe.**
14+
A clear and concise description of the use case for this feature. Please provide an example, if possible.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
*Issue #, if available:*
2+
3+
*Description of changes:*
4+
5+
*Testing done:*
6+
7+
## Merge Checklist
8+
9+
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._
10+
11+
#### General
12+
13+
- [ ] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc
14+
- [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
15+
- [ ] I used the commit message format described in [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md#committing-your-change)
16+
- [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
17+
- [ ] I have updated any necessary documentation, including [READMEs](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) and [API docs](https://github.com/aws/sagemaker-python-sdk/tree/master/doc) (if appropriate)
18+
19+
#### Tests
20+
21+
- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
22+
- [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
23+
- [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
24+
- [ ] I have used [`unique_name_from_base`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/utils.py#L77) to create resource names in integ tests (if appropriate)
25+
- [ ] If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi
26+
27+
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

‎.github/workflows/submodule-codebuild-ci.yml‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
name: Submodule PR Checks
2+
on:
3+
pull_request_target:
4+
branches:
5+
- "master-v3"
6+
paths:
7+
- 'sagemaker_train/**'
8+
- 'sagemaker_utils/**'
9+
10+
concurrency:
11+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.head_ref }}
12+
cancel-in-progress: true
13+
14+
permissions:
15+
id-token: write
16+
17+
jobs:
18+
detect-changes:
19+
runs-on: ubuntu-latest
20+
outputs:
21+
submodules: ${{ steps.check-changes.outputs.submodules }}
22+
steps:
23+
- uses: actions/checkout@v3
24+
- id: check-changes
25+
run: |
26+
CHANGES=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }})
27+
SUBMODULES=[]
28+
29+
if echo "$CHANGES" | grep -q "^sagemaker_train/"; then
30+
SUBMODULES=$(echo $SUBMODULES | jq '. + ["sagemaker_train"]')
31+
fi
32+
if echo "$CHANGES" | grep -q "^sagemaker_utils/"; then
33+
SUBMODULES=$(echo $SUBMODULES | jq '. + ["sagemaker_utils"]')
34+
fi
35+
36+
echo "submodules=$SUBMODULES" >> $GITHUB_OUTPUT
37+
38+
submodule-tests:
39+
needs: [detect-changes]
40+
if: needs.detect-changes.outputs.submodules != '[]'
41+
runs-on: ubuntu-latest
42+
strategy:
43+
matrix:
44+
submodule: ${{ fromJson(needs.detect-changes.outputs.submodules) }}
45+
steps:
46+
- name: Configure AWS Credentials
47+
uses: aws-actions/configure-aws-credentials@v4
48+
with:
49+
role-to-assume: ${{ secrets.CI_AWS_ROLE_ARN }}
50+
aws-region: us-west-2
51+
role-duration-seconds: 10800
52+
53+
- name: Run CodeBuild for ${{ matrix.submodule }}
54+
uses: aws-actions/aws-codebuild-run-build@v1
55+
with:
56+
project-name: ${{ github.event.repository.name }}-ci-${{ matrix.submodule }}
57+
source-version-override: 'refs/pull/${{ github.event.pull_request.number }}/head^{${{ github.event.pull_request.head.sha }}}'

0 commit comments

Comments
 (0)