feat(clients): make profile config unconditional in aws codegen

Author: kuhe

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsRuntimeConfig.java

@@ -99,9 +99,9 @@ public void addConfigInterfaceFields(
                     ? "The AWS region to which this client will send requests"
                     : "The AWS region to use as signing region for AWS Auth")
                 .write("region?: string | __Provider<string>;\n");
+        }
 
-
-            writer.writeDocs(
+        writer.writeDocs(
                 """
                 Setting a client profile is similar to setting a value for the
                 AWS_PROFILE environment variable. Setting a profile on a client
@@ -119,7 +119,6 @@ public void addConfigInterfaceFields(
                 provider options.
                 """)
                 .write("profile?: string;\n");
-        }
     }
 
     @Override
@@ -165,6 +164,8 @@ public void prepareCustomizations(
             writer.addDependency(AwsDependency.AWS_SDK_CORE);
             writer.addImport("emitWarningIfUnsupportedVersion", "awsCheckVersion", AwsDependency.AWS_SDK_CORE);
             writer.write("awsCheckVersion(process.version);");
+        }
+        if (target.equals(LanguageTarget.NODE)) {
             writer.write("const profileConfig = { profile: config?.profile };");
         }
     }

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddUserAgentDependency.java

@@ -84,7 +84,9 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
                             writer.addDependency(AwsDependency.AWS_SDK_UTIL_USER_AGENT_NODE);
                             writer.addImport("NODE_APP_ID_CONFIG_OPTIONS", "NODE_APP_ID_CONFIG_OPTIONS",
                                 AwsDependency.AWS_SDK_UTIL_USER_AGENT_NODE);
-                            writer.write("loadNodeConfig(NODE_APP_ID_CONFIG_OPTIONS, profileConfig)");
+                            writer.write(
+                                "loadNodeConfig(NODE_APP_ID_CONFIG_OPTIONS, profileConfig)"
+                            );
                         }
                 );
             case BROWSER:

private/aws-echo-service/src/EchoServiceClient.ts

@@ -136,6 +136,25 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
    */
   disableHostPrefix?: boolean;
 
+  /**
+   * Setting a client profile is similar to setting a value for the
+   * AWS_PROFILE environment variable. Setting a profile on a client
+   * in code only affects the single client instance, unlike AWS_PROFILE.
+   *
+   * When set, and only for environments where an AWS configuration
+   * file exists, fields configurable by this file will be retrieved
+   * from the specified profile within that file.
+   * Conflicting code configuration and environment variables will
+   * still have higher priority.
+   *
+   * For client credential resolution that involves checking the AWS
+   * configuration file, the client's profile (this value) will be
+   * used unless a different profile is set in the credential
+   * provider options.
+   *
+   */
+  profile?: string;
+
   /**
    * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
    * @internal

private/aws-echo-service/src/runtimeConfig.ts

@@ -23,6 +23,7 @@ export const getRuntimeConfig = (config: EchoServiceClientConfig) => {
   const defaultsMode = resolveDefaultsModeConfig(config);
   const defaultConfigProvider = () => defaultsMode().then(loadConfigsForDefaultMode);
   const clientSharedValues = getSharedRuntimeConfig(config);
+  const profileConfig = { profile: config?.profile };
   return {
     ...clientSharedValues,
     ...config,

private/aws-protocoltests-smithy-rpcv2-cbor/src/RpcV2ProtocolClient.ts

@@ -189,6 +189,25 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
    */
   disableHostPrefix?: boolean;
 
+  /**
+   * Setting a client profile is similar to setting a value for the
+   * AWS_PROFILE environment variable. Setting a profile on a client
+   * in code only affects the single client instance, unlike AWS_PROFILE.
+   *
+   * When set, and only for environments where an AWS configuration
+   * file exists, fields configurable by this file will be retrieved
+   * from the specified profile within that file.
+   * Conflicting code configuration and environment variables will
+   * still have higher priority.
+   *
+   * For client credential resolution that involves checking the AWS
+   * configuration file, the client's profile (this value) will be
+   * used unless a different profile is set in the credential
+   * provider options.
+   *
+   */
+  profile?: string;
+
   /**
    * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
    * @internal

private/aws-protocoltests-smithy-rpcv2-cbor/src/runtimeConfig.ts

@@ -23,6 +23,7 @@ export const getRuntimeConfig = (config: RpcV2ProtocolClientConfig) => {
   const defaultsMode = resolveDefaultsModeConfig(config);
   const defaultConfigProvider = () => defaultsMode().then(loadConfigsForDefaultMode);
   const clientSharedValues = getSharedRuntimeConfig(config);
+  const profileConfig = { profile: config?.profile };
   return {
     ...clientSharedValues,
     ...config,

private/weather-legacy-auth/src/runtimeConfig.ts

@@ -25,6 +25,7 @@ export const getRuntimeConfig = (config: WeatherClientConfig) => {
   const defaultsMode = resolveDefaultsModeConfig(config);
   const defaultConfigProvider = () => defaultsMode().then(loadConfigsForDefaultMode);
   const clientSharedValues = getSharedRuntimeConfig(config);
+  const profileConfig = { profile: config?.profile };
   return {
     ...clientSharedValues,
     ...config,

private/weather/src/runtimeConfig.ts

@@ -25,6 +25,7 @@ export const getRuntimeConfig = (config: WeatherClientConfig) => {
   const defaultsMode = resolveDefaultsModeConfig(config);
   const defaultConfigProvider = () => defaultsMode().then(loadConfigsForDefaultMode);
   const clientSharedValues = getSharedRuntimeConfig(config);
+  const profileConfig = { profile: config?.profile };
   return {
     ...clientSharedValues,
     ...config,