Skip to content

Fix Darwin builds for non-standard environments (e.g. Nix) #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justsmth merged 4 commits into from
Dec 9, 2025
Merged

Fix Darwin builds for non-standard environments (e.g. Nix) #941

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8b6dd0
Fix Darwin builds for non-standard environments (e.g. Nix)
martinjlowm Nov 9, 2025
f745e7d
Conditionally add _DARWIN_C_SOURCE define
justsmth Nov 20, 2025
a85d004
Also for darwin OS
justsmth Nov 20, 2025
ea4d131
Merge branch 'main' into fix/header-error
justsmth Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions aws-lc-sys/builder/cc_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,11 @@ impl CcBuilder {
}
}

if target_os() == "macos" || target_os() == "darwin" {
// Certain MacOS system headers are guarded by _POSIX_C_SOURCE and _DARWIN_C_SOURCE
build_options.push(BuildOption::define("_DARWIN_C_SOURCE", "1"));
}

let opt_level = cargo_env("OPT_LEVEL");
match opt_level.as_str() {
"0" | "1" | "2" => {
Expand Down Expand Up @@ -403,6 +408,10 @@ impl CcBuilder {
};

je_builder.define("AWSLC", "1");
if target_os() == "macos" || target_os() == "darwin" {
// Certain MacOS system headers are guarded by _POSIX_C_SOURCE and _DARWIN_C_SOURCE
je_builder.define("_DARWIN_C_SOURCE", "1");
}
je_builder.pic(true);
if target_os() == "windows" && compiler.is_like_msvc() {
je_builder.flag("/Od").flag("/W4").flag("/DYNAMICBASE");
Expand Down
Loading