fix wait for condition attempt count

Author: anthonyting

packages/aws-durable-execution-sdk-js/src/handlers/wait-for-condition-handler/wait-for-condition-handler.test.ts

@@ -366,7 +366,7 @@ describe("WaitForCondition Handler", () => {
       const config: WaitForConditionConfig<string> = {
         waitStrategy: (state, attempt) => {
           expect(state).toBe("ready");
-          expect(attempt).toBe(2); // Should use attempt from system
+          expect(attempt).toBe(3); // Should increment attempt count
           return { shouldContinue: false };
         },
         initialState: "initial",
@@ -395,7 +395,7 @@ describe("WaitForCondition Handler", () => {
       const config: WaitForConditionConfig<string> = {
         waitStrategy: (state, attempt) => {
           expect(state).toBe("ready");
-          expect(attempt).toBe(2); // Should use attempt from system
+          expect(attempt).toBe(3); // Should increment attempt count
           return { shouldContinue: false };
         },
         initialState: "initial",
@@ -424,7 +424,7 @@ describe("WaitForCondition Handler", () => {
       const config: WaitForConditionConfig<string> = {
         waitStrategy: (state, attempt) => {
           expect(state).toBe("ready");
-          expect(attempt).toBe(2); // Should still use system attempt number
+          expect(attempt).toBe(3); // increment on next wait retry
           return { shouldContinue: false };
         },
         initialState: "initial",
@@ -453,7 +453,7 @@ describe("WaitForCondition Handler", () => {
       const config: WaitForConditionConfig<string> = {
         waitStrategy: (state, attempt) => {
           expect(state).toBe("ready");
-          expect(attempt).toBe(3); // Should use system attempt number
+          expect(attempt).toBe(4); // increment on next wait retry
           return { shouldContinue: false };
         },
         initialState: "initial",
@@ -652,7 +652,7 @@ describe("WaitForCondition Handler", () => {
         "step-1",
         "parent-123", // parentId from handler setup
         expect.any(Function), // The wrapped check function
-        2, // currentAttempt (1) + 1 = 2
+        1, // currentAttempt = 1 (initial attempt only)
         DurableExecutionMode.ExecutionMode,
       );
     });
@@ -707,7 +707,7 @@ describe("WaitForCondition Handler", () => {
         "step-1",
         "parent-123", // parentId should be passed through
         expect.any(Function),
-        2, // currentAttempt (1) + 1 = 2
+        1, // currentAttempt = 1 (initial attempt only)
         DurableExecutionMode.ExecutionMode,
       );
     });

packages/aws-durable-execution-sdk-js/src/handlers/wait-for-condition-handler/wait-for-condition-handler.ts

@@ -307,7 +307,7 @@ export const executeWaitForCondition = async <T, Logger extends DurableLogger>(
   }
 
   // Get the current attempt number (1-based for wait strategy consistency)
-  const currentAttempt = existingOperation?.StepDetails?.Attempt || 1;
+  const currentAttempt = (existingOperation?.StepDetails?.Attempt ?? 0) + 1;
 
   // Checkpoint START for observability (fire and forget) - only if not already started
   const stepData = context.getStepData(stepId);
@@ -336,7 +336,7 @@ export const executeWaitForCondition = async <T, Logger extends DurableLogger>(
         stepId,
         parentId,
         () => check(currentState, waitForConditionContext),
-        currentAttempt + 1,
+        currentAttempt,
         DurableExecutionMode.ExecutionMode,
       );
     } finally {