Skip to content

Commit 64878b8

Browse files
authored
refactor(sdk): remove unused activeOperationsTracker dead code (#358)
- Remove ActiveOperationsTracker class and related files - Update ExecutionContext type to remove activeOperationsTracker property - Simplify CheckpointManager constructor signature - Simplify terminateForUnrecoverableError function - Fix all test files with incorrect constructor parameters - Verified build and all tests pass (2017 tests)
1 parent cc61a4c commit 64878b8

20 files changed

+55
-568
lines changed

package-lock.json

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-durable-execution-sdk-js/src/context/execution-context/execution-context.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ describe("initializeExecutionContext", () => {
138138
durableExecutionClient: mockDurableExecutionClient,
139139
_stepData: {},
140140
terminationManager: expect.any(Object),
141-
activeOperationsTracker: expect.any(Object),
141+
142142
durableExecutionArn: mockDurableExecutionArn,
143143
pendingCompletions: expect.any(Set),
144144
getStepData: expect.any(Function),

packages/aws-durable-execution-sdk-js/src/context/execution-context/execution-context.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
import { log } from "../../utils/logger/logger";
99
import { getStepData as getStepDataUtil } from "../../utils/step-id-utils/step-id-utils";
1010
import { createDefaultLogger } from "../../utils/logger/default-logger";
11-
import { ActiveOperationsTracker } from "../../utils/termination-helper/active-operations-tracker";
11+
1212
import { Context } from "aws-lambda";
1313
import { DurableExecutionApiClient } from "../../durable-execution-api-client/durable-execution-api-client";
1414
import { DurableExecutionInvocationInputWithClient } from "../../utils/durable-execution-invocation-input/durable-execution-invocation-input";
@@ -84,7 +84,7 @@ export const initializeExecutionContext = async (
8484
durableExecutionClient,
8585
_stepData: stepData,
8686
terminationManager: new TerminationManager(),
87-
activeOperationsTracker: new ActiveOperationsTracker(),
87+
8888
durableExecutionArn,
8989
pendingCompletions: new Set<string>(),
9090
getStepData(stepId: string): Operation | undefined {

packages/aws-durable-execution-sdk-js/src/termination-manager/termination-manager-checkpoint.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const createCheckpoint = (
1818
{},
1919
context.durableExecutionClient,
2020
context.terminationManager,
21-
undefined,
2221
token,
2322
emitter,
2423
logger,

packages/aws-durable-execution-sdk-js/src/testing/create-test-checkpoint-manager.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export const createTestCheckpointManager = (
1313
context._stepData,
1414
context.durableExecutionClient,
1515
context.terminationManager,
16-
context.activeOperationsTracker,
1716
checkpointToken,
1817
emitter,
1918
logger,

packages/aws-durable-execution-sdk-js/src/testing/create-test-durable-context.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export function createTestDurableContext(options?: {
8282
},
8383
requestId: "mock-request-id",
8484
tenantId: undefined,
85-
activeOperationsTracker: undefined,
8685
};
8786

8887
const mockLambdaContext: Context = {

packages/aws-durable-execution-sdk-js/src/testing/mock-checkpoint-manager.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export class MockCheckpointManager extends CheckpointManager {
2020
{},
2121
{} as DurableExecutionClient,
2222
{} as TerminationManager,
23-
undefined,
2423
"mock-token",
2524
{} as EventEmitter,
2625
{} as DurableLogger,

packages/aws-durable-execution-sdk-js/src/types/core.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { TerminationManager } from "../termination-manager/termination-manager";
22
import { DurableExecutionClient } from "./durable-execution";
33
import { ErrorObject, Operation } from "@aws-sdk/client-lambda";
4-
import { ActiveOperationsTracker } from "../utils/termination-helper/active-operations-tracker";
54

65
/**
76
* @internal
@@ -323,7 +322,7 @@ export interface ExecutionContext {
323322
_stepData: Record<string, Operation>; // Private, use getStepData() instead
324323
terminationManager: TerminationManager;
325324
durableExecutionArn: string;
326-
activeOperationsTracker?: ActiveOperationsTracker;
325+
327326
requestId: string;
328327
tenantId: string | undefined;
329328
pendingCompletions: Set<string>; // Track stepIds with pending SUCCEED/FAIL

packages/aws-durable-execution-sdk-js/src/utils/checkpoint/checkpoint-central-termination.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ describe("CheckpointManager - Centralized Termination", () => {
3333
{},
3434
mockClient,
3535
mockTerminationManager,
36-
undefined,
3736
"test-token",
3837
mockStepDataEmitter,
3938
{} as any,

packages/aws-durable-execution-sdk-js/src/utils/checkpoint/checkpoint-integration.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ describe("Checkpoint Integration Tests", () => {
5252
{},
5353
mockState,
5454
{ terminate: jest.fn() } as any,
55-
undefined,
5655
TEST_CONSTANTS.CHECKPOINT_TOKEN,
5756
mockEmitter,
5857
mockLogger,
@@ -90,7 +89,6 @@ describe("Checkpoint Integration Tests", () => {
9089
{},
9190
mockState,
9291
{ terminate: jest.fn() } as any,
93-
undefined,
9492
TEST_CONSTANTS.CHECKPOINT_TOKEN,
9593
mockEmitter,
9694
mockLogger,
@@ -177,7 +175,6 @@ describe("Checkpoint Integration Tests", () => {
177175
{},
178176
mockState,
179177
{ terminate: jest.fn() } as any,
180-
undefined,
181178
TEST_CONSTANTS.CHECKPOINT_TOKEN,
182179
mockEmitter,
183180
mockLogger,
@@ -217,7 +214,6 @@ describe("Checkpoint Integration Tests", () => {
217214
{},
218215
mockState,
219216
{ terminate: jest.fn() } as any,
220-
undefined,
221217
TEST_CONSTANTS.CHECKPOINT_TOKEN,
222218
mockEmitter,
223219
mockLogger,
@@ -270,7 +266,6 @@ describe("Checkpoint Integration Tests", () => {
270266
{},
271267
mockState,
272268
{ terminate: jest.fn() } as any,
273-
undefined,
274269
TEST_CONSTANTS.CHECKPOINT_TOKEN,
275270
mockEmitter,
276271
mockLogger,
@@ -284,7 +279,6 @@ describe("Checkpoint Integration Tests", () => {
284279
{},
285280
mockState2,
286281
{ terminate: jest.fn() } as any,
287-
undefined,
288282
TEST_CONSTANTS.CHECKPOINT_TOKEN,
289283
mockEmitter,
290284
mockLogger,

0 commit comments

Comments
 (0)