Commit 4d555c9
authored
fix: cdk flags outputs empty table when recommended flags are already set (#836)
Fixes #834
### Description
DX improvement.
Previously, when the user ran `cdk flags` but already had all
recommended flags configured, an empty table was displayed.
<img width="1177" height="160" alt="Screenshot 2025-09-03 at 12 01 43"
src="https://github.com/user-attachments/assets/3b41df96-4256-49a3-88fc-1e405a04d8e8"
/>
*No context here, what does the table mean?*
In this change, we added a message to inform the user why they are
seeing an empty table. We still print the table to maintain API
consistency.
<img width="1102" height="542" alt="Screenshot 2025-09-05 at 21 16 11"
src="https://github.com/user-attachments/assets/6c389d01-31b2-4c48-a609-fa545f5453f1"
/>
*Now the user knows why the table is empty, and is given guidance to
display all flags*
### Testing
Added unit tests for positive and negative cases.
---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license1 parent ccef4c6 commit 4d555c9
File tree
2 files changed
+69
-0
lines changed- packages/aws-cdk
- lib/commands
- test/commands
2 files changed
+69
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
477 | 477 | | |
478 | 478 | | |
479 | 479 | | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
480 | 487 | | |
481 | 488 | | |
482 | 489 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
328 | 390 | | |
329 | 391 | | |
330 | 392 | | |
| |||
0 commit comments