rm default value at cli-config.ts

Author: ren-yamanashi

packages/aws-cdk/lib/cli/cli-config.ts

@@ -4,7 +4,7 @@ import { CliHelpers, type CliConfig } from '@aws-cdk/user-input-gen';
 import * as cdk_from_cfn from 'cdk-from-cfn';
 import { StackActivityProgress } from '../commands/deploy';
 import { availableInitLanguages } from '../commands/init';
-import { JS_PACKAGE_MANAGER } from '../commands/init/package-manager';
+import { JS_PACKAGE_MANAGERS } from '../commands/init/package-manager';
 import { getLanguageAlias } from '../commands/language';
 
 export const YARGS_HELPERS = new CliHelpers('./util/yargs-helpers');
@@ -408,7 +408,7 @@ export async function makeConfig(): Promise<CliConfig> {
           'lib-version': { type: 'string', alias: 'V', default: undefined, desc: 'The version of the CDK library (aws-cdk-lib) to initialize built-in templates with. Defaults to the version that was current when this CLI was built.' },
           'from-path': { type: 'string', desc: 'Path to a local custom template directory or multi-template repository', requiresArg: true, conflicts: ['lib-version'] },
           'template-path': { type: 'string', desc: 'Path to a specific template within a multi-template repository', requiresArg: true },
-          'package-manager': { type: 'string', desc: 'The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects.', default: JS_PACKAGE_MANAGER.NPM, choices: Object.values(JS_PACKAGE_MANAGER) },
+          'package-manager': { type: 'string', desc: 'The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects. Defaults to npm in TypeScript and JavaScript projects.', choices: JS_PACKAGE_MANAGERS },
         },
         implies: { 'template-path': 'from-path' },
       },

packages/aws-cdk/lib/cli/cli-type-registry.json

@@ -906,8 +906,7 @@
         },
         "package-manager": {
           "type": "string",
-          "desc": "The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects.",
-          "default": "npm",
+          "desc": "The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects. Defaults to npm in TypeScript and JavaScript projects.",
           "choices": [
             "npm",
             "yarn",

packages/aws-cdk/lib/cli/parse-command-line-arguments.ts

@@ -896,9 +896,9 @@ export function parseCommandLineArguments(args: Array<string>): any {
           requiresArg: true,
         })
         .option('package-manager', {
-          default: 'npm',
+          default: undefined,
           type: 'string',
-          desc: 'The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects.',
+          desc: 'The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects. Defaults to npm in TypeScript and JavaScript projects.',
           choices: ['npm', 'yarn', 'pnpm', 'bun'],
         }),
     )

packages/aws-cdk/lib/cli/user-input.ts

@@ -1409,9 +1409,9 @@ export interface InitOptions {
   readonly templatePath?: string;
 
   /**
-   * The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects.
+   * The package manager to use to install dependencies. Only applicable for TypeScript and JavaScript projects. Defaults to npm in TypeScript and JavaScript projects.
    *
-   * @default - "npm"
+   * @default - undefined
    */
   readonly packageManager?: string;
 

packages/aws-cdk/lib/commands/init/init.ts

@@ -80,7 +80,7 @@ export interface CliInitOptions {
   /**
    * The package manager to use for installing dependencies.
    * Only applicable for TypeScript and JavaScript projects.
-   * @default "npm"
+   * @default - If specified language is 'typescript' or 'javascript', 'npm' is selected. Otherwise, no package manager is used.
    */
   readonly packageManager?: JsPackageManager;
 

packages/aws-cdk/lib/commands/init/package-manager.ts

@@ -1,8 +1,3 @@
-export const JS_PACKAGE_MANAGER = {
-  NPM: 'npm',
-  YARN: 'yarn',
-  PNPM: 'pnpm',
-  BUN: 'bun',
-} as const;
+export const JS_PACKAGE_MANAGERS = ['npm', 'yarn', 'pnpm', 'bun'] as const;
 
-export type JsPackageManager = typeof JS_PACKAGE_MANAGER[keyof typeof JS_PACKAGE_MANAGER];
+export type JsPackageManager = (typeof JS_PACKAGE_MANAGERS)[number];

packages/aws-cdk/test/commands/init.test.ts

@@ -1453,6 +1453,33 @@ describe('constructs version', () => {
       });
     });
 
+    test.each([
+      'python',
+      'java',
+      'go',
+      'csharp',
+      'fsharp',
+    ])('does not warn when package-manager option is omitted for non-JS language=%s', async (language) => {
+      await withTempDir(async (workDir) => {
+        const warnSpy = jest.spyOn(ioHelper.defaults, 'warn');
+
+        await cliInit({
+          ioHelper,
+          type: 'app',
+          language,
+          canUseNetwork: false,
+          generateOnly: true,
+          workDir,
+        });
+
+        expect(warnSpy).not.toHaveBeenCalledWith(
+          expect.stringContaining('--package-manager option is only applicable for JavaScript and TypeScript projects'),
+        );
+
+        warnSpy.mockRestore();
+      });
+    });
+
     test.each([
       'typescript',
       'javascript',