Skip to content

Commit d8153e5

Browse files
Better logic for IDE
1 parent ce81edd commit d8153e5

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

tests/test_ide.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -337,15 +337,10 @@ def test_studio_notebook_in_firefox(request):
337337
assert "JupyterLab" in browser.title
338338

339339
logging.info("Waiting for SageMaker Studio to launch")
340-
kernel_menu_xpath = "//div[@class='lm-MenuBar-itemLabel p-MenuBar-itemLabel' " \
341-
"and text()='Kernel']"
342-
WebDriverWait(browser, 30).until(
343-
EC.presence_of_element_located((By.XPATH, kernel_menu_xpath))
340+
WebDriverWait(browser, 300).until(
341+
EC.presence_of_element_located((By.XPATH, "//div[@id='jp-MainLogo']"))
344342
)
345343
time.sleep(15) # wait until obscurity of the menu item is gone and UI is fully loaded
346-
kernel_menu_item = browser.find_element(By.XPATH, kernel_menu_xpath)
347-
logging.info(f"Found SageMaker Studio kernel menu item: {kernel_menu_item}")
348-
kernel_menu_item.click()
349344

350345
# TODO: ide.upload_ssh("../SageMaker_SSH_IDE.ipynb", "/root/SageMaker_SSH_IDE-DS2-CPU.ipynb")
351346
# TODO: ide.upload_UI("../SageMaker_SSH_IDE.ipynb", "/SageMaker_SSH_IDE-DS2-CPU.ipynb")
@@ -356,6 +351,12 @@ def test_studio_notebook_in_firefox(request):
356351
# "pip3 install -U ./sagemaker-ssh-helper/"
357352
# ])
358353

354+
kernel_menu_xpath = "//div[@class='lm-MenuBar-itemLabel p-MenuBar-itemLabel' " \
355+
"and text()='Kernel']"
356+
kernel_menu_item = browser.find_element(By.XPATH, kernel_menu_xpath)
357+
logging.info(f"Found SageMaker Studio kernel menu item: {kernel_menu_item}")
358+
kernel_menu_item.click()
359+
359360
logging.info("Restarting kernel and running all cells")
360361
restart_menu_xpath = "//div[@class='lm-Menu-itemLabel p-Menu-itemLabel' " \
361362
"and text()='Restart Kernel and Run All Cells…']"

0 commit comments

Comments
 (0)