Skip to content

Commit 5130896

Browse files
Version bump to 2.3.1.dev0
1 parent 0eff859 commit 5130896

File tree

9 files changed

+12
-13
lines changed

9 files changed

+12
-13
lines changed

.idea/deployment.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/misc.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/sagemaker-ssh-helper.iml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -552,12 +552,6 @@ Alternatively, instead of using `sm-ssh connect` command, you can use the native
552552

553553
```bash
554554
Host *.studio.sagemaker
555-
IdentityFile ~/.ssh/%h
556-
PasswordAuthentication no
557-
ConnectTimeout 120
558-
ServerAliveInterval 15
559-
ServerAliveCountMax 8
560-
ProxyCommand sm-ssh start-proxy %h
561555
User sagemaker-user
562556

563557
Host *.*.sagemaker

profile_tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
set -e
44
set -o pipefail
55

6-
echo "Keywords expression for pytest (PYTEST_KEYWORDS): -k '$PYTEST_KEYWORDS'"
7-
echo "Extra args for pytest (PYTEST_EXTRA_ARGS): $PYTEST_EXTRA_ARGS"
6+
echo "Keywords expression for pytest (-k PYTEST_KEYWORDS): ['$PYTEST_KEYWORDS']"
7+
echo "Extra args for pytest (PYTEST_EXTRA_ARGS): [$PYTEST_EXTRA_ARGS]"
88
python -m venv ./venv
99
source ./venv/bin/activate
1010
pip install '.[test]'

run_tests.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ AWS_DEFAULT_REGION=eu-west-1 sm-ssh list
119119
AWS_DEFAULT_REGION=eu-west-2 sm-ssh list
120120
mkdir -p /root/.ssh
121121
cat ssh_config_template.txt >>/root/.ssh/config
122+
echo "Hello from the notebook:"
122123
ssh -o StrictHostKeyChecking=no ssh-helper-notebook.notebook.sagemaker \
123124
python --version || echo "ERROR: cannot connect to notebook"
124125

sagemaker_ssh_helper/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.3.0
1+
2.3.1.dev0

ssh_config_template.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
# *.transform.sagemaker
66
# *.processing.sagemaker
77
# *.notebook.sagemaker
8+
9+
Host *.studio.sagemaker
10+
User sagemaker-user
11+
812
Host *.*.sagemaker
913
IdentityFile ~/.ssh/%h
1014
PasswordAuthentication no

tests/test_local.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ def test_local_training():
4646

4747
@mock.patch.dict(os.environ, {"SM_MODEL_DIR": os.path.join(os.path.dirname(__file__), "opt_ml/model")})
4848
def test_local_training_with_coverage():
49-
# import will start training
49+
# import will start training without subprocess, so we have code coverage
5050
from source_dir.training_clean import train_clean
5151
assert train_clean

0 commit comments

Comments
 (0)