Remove AWS_OFI_NCCL_VERSION #911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanshanbhag
requested changes
Nov 27, 2025
| > |`CUDA_VERSION` | `12.8.1` | | | ||
| > |`GDRCOPY_VERSION` | `v2.5.1` | [link](https://github.com/NVIDIA/gdrcopy) | | ||
| > |`EFA_INSTALLER_VERSION`| `1.43.2` | [link](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-start.html#efa-start-enable) | | ||
| > |`AWS_OFI_NCCL_VERSION` | `v1.16.3` | [link](https://github.com/aws/aws-ofi-nccl) | |
Contributor
There was a problem hiding this comment.
Can you still add a line to the readme that shows folks how they can install OFI NCCL version (and why this was removed — because it’s now bundled in with efa installation)?
| ```bash | ||
| docker build -f nccl-tests.Dockerfile \ | ||
| --build-arg="EFA_INSTALLER_VERSION=${EFA_INSTALLER_VERSION}" \ | ||
| --build-arg="AWS_OFI_NCCL_VERSION=${AWS_OFI_NCCL_VERSION}" \ |
Contributor
There was a problem hiding this comment.
Either comment out, or add a comment below that shows how folks with older efa versions can build with ofi Nccl installation.
just for the short term, until we get a couple more efa installer versions.
| kubectl logs -f $(kubectl get pods | grep launcher | cut -d ' ' -f 1) | ||
| ``` | ||
|
|
||
| The following is an example exerpt from the logs of a NCCL all_reduce_perf test, executed on a cluster with two p5.48xlarge instances (using EFA_INSTALLER_VERSION=1.28.0, AWS_OFI_NCCL_VERSION=v1.7.3-aws, NCCL_TESTS_VERSION=master, ARG NCCL_VERSION=2.18.5): |
|
|
||
| ARG GDRCOPY_VERSION=v2.5.1 | ||
| ARG EFA_INSTALLER_VERSION=1.43.2 | ||
| ARG AWS_OFI_NCCL_VERSION=v1.16.3 |
Contributor
|
What is the motivation behind removal of it? it doesn't hurt we include it as we don't use it by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.