Skip to content

Commit ebbc903

Browse files
phipagphipag
committed
Make all tests package-private.
1 parent aa4ce4d commit ebbc903

File tree

15 files changed

+113
-113
lines changed

15 files changed

+113
-113
lines changed

‎powertools-parameters/powertools-parameters-appconfig/src/test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigParamAspectTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
import org.junit.jupiter.api.Test;
2323
import org.mockito.Mockito;
2424

25-
public class AppConfigParamAspectTest {
25+
class AppConfigParamAspectTest {
2626

2727
@Test
28-
public void parameterInjectedByProvider() throws Exception {
28+
void parameterInjectedByProvider() throws Exception {
2929
// Setup our aspect to return a mocked AppConfigProvider
3030
String environment = "myEnvironment";
3131
String appName = "myApp";

‎powertools-parameters/powertools-parameters-dynamodb/src/test/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbParamAspectTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import org.junit.jupiter.api.Test;
2222
import org.mockito.Mockito;
2323

24-
public class DynamoDbParamAspectTest {
24+
class DynamoDbParamAspectTest {
2525

2626
@Test
27-
public void parameterInjectedByProvider() throws Exception {
27+
void parameterInjectedByProvider() throws Exception {
2828
// Setup our aspect to return a mocked DynamoDbProvider
2929
String tableName = "my-test-tablename";
3030
String key = "myKey";

‎powertools-parameters/powertools-parameters-dynamodb/src/test/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderE2ETest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
* will move this across.
3737
*/
3838
@Disabled
39-
public class DynamoDbProviderE2ETest {
39+
class DynamoDbProviderE2ETest {
4040

4141
final String ParamsTestTable = "ddb-params-test";
4242
final String MultiparamsTestTable = "ddb-multiparams-test";
@@ -52,7 +52,7 @@ public DynamoDbProviderE2ETest() {
5252
}
5353

5454
@Test
55-
public void TestGetValue() {
55+
void TestGetValue() {
5656

5757
// Arrange
5858
HashMap<String, AttributeValue> testItem = new HashMap<String, AttributeValue>();
@@ -72,7 +72,7 @@ public void TestGetValue() {
7272
}
7373

7474
@Test
75-
public void TestGetValues() {
75+
void TestGetValues() {
7676

7777
// Arrange
7878
HashMap<String, AttributeValue> testItem = new HashMap<String, AttributeValue>();

‎powertools-parameters/powertools-parameters-dynamodb/src/test/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderTest.java‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import software.amazon.lambda.powertools.parameters.transform.TransformationManager;
4646

4747
@ExtendWith(MockitoExtension.class)
48-
public class DynamoDbProviderTest {
48+
class DynamoDbProviderTest {
4949

5050
private final String tableName = "ddb-test-table";
5151

@@ -64,14 +64,14 @@ public class DynamoDbProviderTest {
6464
private DynamoDbProvider provider;
6565

6666
@BeforeEach
67-
public void init() {
67+
void init() {
6868
openMocks(this);
6969
CacheManager cacheManager = new CacheManager();
7070
provider = new DynamoDbProvider(cacheManager, transformationManager, client, tableName);
7171
}
7272

7373
@Test
74-
public void getValue() {
74+
void getValue() {
7575

7676
// Arrange
7777
String key = "Key1";
@@ -94,7 +94,7 @@ public void getValue() {
9494
}
9595

9696
@Test
97-
public void getValueWithNullResultsReturnsNull() {
97+
void getValueWithNullResultsReturnsNull() {
9898
// Arrange
9999
Mockito.when(client.getItem(getItemValueCaptor.capture())).thenReturn(GetItemResponse.builder()
100100
.item(null)
@@ -108,7 +108,7 @@ public void getValueWithNullResultsReturnsNull() {
108108
}
109109

110110
@Test
111-
public void getValueWithoutResultsReturnsNull() {
111+
void getValueWithoutResultsReturnsNull() {
112112
// Arrange
113113
Mockito.when(client.getItem(getItemValueCaptor.capture())).thenReturn(GetItemResponse.builder()
114114
.item(new HashMap<>())
@@ -122,7 +122,7 @@ public void getValueWithoutResultsReturnsNull() {
122122
}
123123

124124
@Test
125-
public void getValueWithMalformedRowThrows() {
125+
void getValueWithMalformedRowThrows() {
126126
// Arrange
127127
String key = "Key1";
128128
HashMap<String, AttributeValue> responseData = new HashMap<String, AttributeValue>();
@@ -138,7 +138,7 @@ public void getValueWithMalformedRowThrows() {
138138
}
139139

140140
@Test
141-
public void getValues() {
141+
void getValues() {
142142

143143
// Arrange
144144
String key = "Key1";
@@ -172,7 +172,7 @@ public void getValues() {
172172
}
173173

174174
@Test
175-
public void getValuesWithoutResultsReturnsNull() {
175+
void getValuesWithoutResultsReturnsNull() {
176176
// Arrange
177177
Mockito.when(client.query(queryRequestCaptor.capture())).thenReturn(
178178
QueryResponse.builder().items().build());
@@ -185,7 +185,7 @@ public void getValuesWithoutResultsReturnsNull() {
185185
}
186186

187187
@Test
188-
public void getMultipleValuesMissingSortKey_throwsException() {
188+
void getMultipleValuesMissingSortKey_throwsException() {
189189
// Arrange
190190
String key = "Key1";
191191
HashMap<String, AttributeValue> item = new HashMap<String, AttributeValue>();
@@ -204,7 +204,7 @@ public void getMultipleValuesMissingSortKey_throwsException() {
204204
}
205205

206206
@Test
207-
public void getValuesWithMalformedRowThrows() {
207+
void getValuesWithMalformedRowThrows() {
208208
// Arrange
209209
String key = "Key1";
210210
HashMap<String, AttributeValue> item1 = new HashMap<String, AttributeValue>();
@@ -224,7 +224,7 @@ public void getValuesWithMalformedRowThrows() {
224224
}
225225

226226
@Test
227-
public void testDynamoDBBuilderMissingTable_throwsException() {
227+
void testDynamoDBBuilderMissingTable_throwsException() {
228228

229229
// Act & Assert
230230
assertThatIllegalStateException().isThrownBy(() -> DynamoDbProvider.builder()
@@ -233,7 +233,7 @@ public void testDynamoDBBuilderMissingTable_throwsException() {
233233
}
234234

235235
@Test
236-
public void testDynamoDBBuilder_withoutParameter_shouldHaveDefaultTransformationManager() {
236+
void testDynamoDBBuilder_withoutParameter_shouldHaveDefaultTransformationManager() {
237237

238238
// Act
239239
DynamoDbProvider dynamoDbProvider = DynamoDbProvider.builder().withTable("test-table")

‎powertools-parameters/powertools-parameters-secrets/src/test/java/software/amazon/lambda/powertools/parameters/secrets/SecretsParamAspectTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import org.junit.jupiter.api.Test;
2222
import org.mockito.Mockito;
2323

24-
public class SecretsParamAspectTest {
24+
class SecretsParamAspectTest {
2525

2626
@Test
27-
public void parameterInjectedByProvider() throws Exception {
27+
void parameterInjectedByProvider() throws Exception {
2828
// Setup our aspect to return a mocked SecretsProvider
2929
String key = "myKey";
3030
String value = "mySecretValue";

‎powertools-parameters/powertools-parameters-secrets/src/test/java/software/amazon/lambda/powertools/parameters/secrets/SecretsProviderTest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import software.amazon.lambda.powertools.parameters.transform.TransformationManager;
4141

4242
@ExtendWith(MockitoExtension.class)
43-
public class SecretsProviderTest {
43+
class SecretsProviderTest {
4444

4545
@Mock
4646
SecretsManagerClient client;
@@ -56,13 +56,13 @@ public class SecretsProviderTest {
5656
SecretsProvider provider;
5757

5858
@BeforeEach
59-
public void init() {
59+
void init() {
6060
cacheManager = new CacheManager();
6161
provider = new SecretsProvider(cacheManager, transformationManager, client);
6262
}
6363

6464
@Test
65-
public void getValue() {
65+
void getValue() {
6666
String key = "Key1";
6767
String expectedValue = "Value1";
6868
GetSecretValueResponse response = GetSecretValueResponse.builder().secretString(expectedValue).build();
@@ -76,7 +76,7 @@ public void getValue() {
7676
}
7777

7878
@Test
79-
public void getValueBase64() {
79+
void getValueBase64() {
8080
String key = "Key2";
8181
String expectedValue = "Value2";
8282
byte[] valueb64 = Base64.getEncoder().encode(expectedValue.getBytes());
@@ -91,14 +91,14 @@ public void getValueBase64() {
9191
}
9292

9393
@Test
94-
public void getMultipleValuesThrowsException() {
94+
void getMultipleValuesThrowsException() {
9595
// Act & Assert
9696
assertThatRuntimeException().isThrownBy(() -> provider.getMultipleValues("path"))
9797
.withMessage("Impossible to get multiple values from AWS Secrets Manager");
9898
}
9999

100100
@Test
101-
public void testGetSecretsProvider_withoutParameter_shouldCreateDefaultClient() {
101+
void testGetSecretsProvider_withoutParameter_shouldCreateDefaultClient() {
102102
// Act
103103
SecretsProvider secretsProvider = SecretsProvider.builder()
104104
.build();
@@ -109,7 +109,7 @@ public void testGetSecretsProvider_withoutParameter_shouldCreateDefaultClient()
109109
}
110110

111111
@Test
112-
public void testGetSecretsProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
112+
void testGetSecretsProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
113113
// Act
114114
SecretsProvider secretsProvider = SecretsProvider.builder()
115115
.build();

‎powertools-parameters/powertools-parameters-ssm/src/test/java/software/amazon/lambda/powertools/parameters/ssm/SSMParamAspectTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
import org.junit.jupiter.api.Test;
2222
import org.mockito.Mockito;
2323

24-
public class SSMParamAspectTest {
24+
class SSMParamAspectTest {
2525

2626
// This class tests the SSM Param aspect in the same fashion
2727
// as the tests for the aspects for the other providers.
2828

2929
@Test
30-
public void parameterInjectedByProvider() throws Exception {
30+
void parameterInjectedByProvider() throws Exception {
3131

3232
String key = "myKey";
3333
String value = "mySecretValue";

‎powertools-parameters/powertools-parameters-ssm/src/test/java/software/amazon/lambda/powertools/parameters/ssm/SSMProviderTest.java‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
import software.amazon.lambda.powertools.parameters.cache.CacheManager;
4545
import software.amazon.lambda.powertools.parameters.transform.TransformationManager;
4646

47-
public class SSMProviderTest {
47+
class SSMProviderTest {
4848

4949
@Mock
5050
SsmClient client;
@@ -63,14 +63,14 @@ public class SSMProviderTest {
6363
SSMProvider provider;
6464

6565
@BeforeEach
66-
public void init() {
66+
void init() {
6767
MockitoAnnotations.openMocks(this);
6868
cacheManager = new CacheManager();
6969
provider = new SSMProvider(cacheManager, null, client);
7070
}
7171

7272
@Test
73-
public void getValue() {
73+
void getValue() {
7474
String key = "Key1";
7575
String expectedValue = "Value1";
7676
initMock(expectedValue);
@@ -83,7 +83,7 @@ public void getValue() {
8383
}
8484

8585
@Test
86-
public void getValueDecrypted() {
86+
void getValueDecrypted() {
8787
String key = "Key2";
8888
String expectedValue = "Value2";
8989
initMock(expectedValue);
@@ -96,7 +96,7 @@ public void getValueDecrypted() {
9696
}
9797

9898
@Test
99-
public void getMultiple() {
99+
void getMultiple() {
100100
List<Parameter> parameters = new ArrayList<>();
101101
parameters.add(Parameter.builder().name("/prod/app1/key1").value("foo1").build());
102102
parameters.add(Parameter.builder().name("/prod/app1/key2").value("foo2").build());
@@ -119,7 +119,7 @@ public void getMultiple() {
119119
}
120120

121121
@Test
122-
public void getMultipleWithTrailingSlash() {
122+
void getMultipleWithTrailingSlash() {
123123
List<Parameter> parameters = new ArrayList<>();
124124
parameters.add(Parameter.builder().name("/prod/app1/key1").value("foo1").build());
125125
parameters.add(Parameter.builder().name("/prod/app1/key2").value("foo2").build());
@@ -142,7 +142,7 @@ public void getMultipleWithTrailingSlash() {
142142
}
143143

144144
@Test
145-
public void getMultiple_cached_shouldNotCallSSM() {
145+
void getMultiple_cached_shouldNotCallSSM() {
146146
List<Parameter> parameters = new ArrayList<>();
147147
parameters.add(Parameter.builder().name("/prod/app1/key1").value("foo1").build());
148148
parameters.add(Parameter.builder().name("/prod/app1/key2").value("foo2").build());
@@ -164,7 +164,7 @@ public void getMultiple_cached_shouldNotCallSSM() {
164164
}
165165

166166
@Test
167-
public void getMultipleWithNextToken() {
167+
void getMultipleWithNextToken() {
168168
List<Parameter> parameters1 = new ArrayList<>();
169169
parameters1.add(Parameter.builder().name("/prod/app1/key1").value("foo1").build());
170170
parameters1.add(Parameter.builder().name("/prod/app1/key2").value("foo2").build());
@@ -199,7 +199,7 @@ public void getMultipleWithNextToken() {
199199
}
200200

201201
@Test
202-
public void testSSMProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
202+
void testSSMProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
203203

204204
// Act
205205
SSMProvider ssmProvider = SSMProvider.builder()
@@ -209,7 +209,7 @@ public void testSSMProvider_withoutParameter_shouldHaveDefaultTransformationMana
209209
}
210210

211211
@Test
212-
public void withDecryption_concurrentCalls_shouldBeThreadSafe() throws InterruptedException {
212+
void withDecryption_concurrentCalls_shouldBeThreadSafe() throws InterruptedException {
213213
// GIVEN
214214
Parameter param1 = Parameter.builder().value("value1").build();
215215
Parameter param2 = Parameter.builder().value("value2").build();
@@ -255,7 +255,7 @@ public void withDecryption_concurrentCalls_shouldBeThreadSafe() throws Interrupt
255255
}
256256

257257
@Test
258-
public void recursive_concurrentCalls_shouldBeThreadSafe() throws InterruptedException {
258+
void recursive_concurrentCalls_shouldBeThreadSafe() throws InterruptedException {
259259
// GIVEN
260260
List<Parameter> params1 = new ArrayList<>();
261261
params1.add(Parameter.builder().name("/path1/key1").value("value1").build());

0 commit comments

Comments
 (0)