Fix PMD findings.

Author: phipag

powertools-parameters/powertools-parameters-tests/src/test/java/software/amazon/lambda/powertools/parameters/BaseProviderTest.java

@@ -199,7 +199,7 @@ void get_complexTransformation_shouldTransformInObject() {
                 ObjectToDeserialize.class);
 
         assertThat(objectToDeserialize).matches(
-                o -> o.getFoo().equals("Foo")
+                o -> "Foo".equals(o.getFoo())
                         && o.getBar() == 42
                         && o.getBaz() == 123456789);
     }

powertools-parameters/powertools-parameters-tests/src/test/java/software/amazon/lambda/powertools/parameters/transform/JsonTransformerTest.java

@@ -32,7 +32,7 @@ void transform_json_shouldTransformInObject() throws TransformationException {
                 transformation.applyTransformation("{\"foo\":\"Foo\", \"bar\":42, \"baz\":123456789}",
                         ObjectToDeserialize.class);
         assertThat(objectToDeserialize).matches(
-                o -> o.getFoo().equals("Foo")
+                o -> "Foo".equals(o.getFoo())
                         && o.getBar() == 42
                         && o.getBaz() == 123456789);
     }

powertools-parameters/powertools-parameters-tests/src/test/java/software/amazon/lambda/powertools/parameters/transform/TransformationManagerTest.java

@@ -136,7 +136,7 @@ void setTransformer_concurrentCalls_shouldBeThreadSafe() throws InterruptedExcep
                 String result = manager.performComplexTransformation(
                         "{\"foo\":\"Foo\", \"bar\":42, \"baz\":123456789}",
                         ObjectToDeserialize.class).getFoo();
-                success[0] = result.equals("Foo");
+                success[0] = "Foo".equals(result);
             } catch (Exception e) {
                 e.printStackTrace();
                 success[0] = false;
@@ -151,7 +151,7 @@ void setTransformer_concurrentCalls_shouldBeThreadSafe() throws InterruptedExcep
                 // Thread 2 expects base64 transformer
                 String result = manager.performBasicTransformation(
                         Base64.getEncoder().encodeToString("bar".getBytes()));
-                success[1] = result.equals("bar");
+                success[1] = "bar".equals(result);
             } catch (Exception e) {
                 e.printStackTrace();
                 success[1] = false;

powertools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/cache/DataStore.java

@@ -15,14 +15,15 @@
 package software.amazon.lambda.powertools.parameters.cache;
 
 import java.time.Instant;
+import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * Internal store used to cache parameters
  */
 public class DataStore {
 
-    private final ConcurrentHashMap<String, ValueNode> store;
+    private final Map<String, ValueNode> store;
 
     public DataStore() {
         this.store = new ConcurrentHashMap<>();
@@ -32,8 +33,8 @@ public void put(String key, Object value, Instant time) {
         store.put(key, new ValueNode(value, time));
     }
 
-    public void remove(String Key) {
-        store.remove(Key);
+    public void remove(String key) {
+        store.remove(key);
     }
 
     public Object get(String key) {