Adding first test

rodrigobersa · rodrigobersa · commit be0aecba0d6b · 2023-08-22T20:02:58.000-04:00
diff --git a/.header.md b/.header.md
@@ -1,63 +1,14 @@
-# Creating modules for AWS I&A Organization
+# Terraform Module for AWS Shield Advanced
 
-This repo template is used to seed Terraform Module templates for the [AWS I&A GitHub organization](https://github.com/aws-ia). Usage of this template is allowed per included license. PRs to this template will be considered but are not guaranteed to be included. Consider creating an issue to discuss a feature you want to include before taking the time to create a PR.
+Terraform module that creates AWS Shield Advanced Resources
 
-<!-- markdownlint-disable MD001 -->
-### TL;DR
+- [Terraform Module for AWS Shield Advanced](#terraform-module-for-aws-shield-advanced)
+  - [Usage](#usage)
+  - [Overview Diagrams](#overview-diagrams)
+  - [Terraform Module](#terraform-module)
 
-1. [install pre-commit](https://pre-commit.com/#install)
-    - Prerequisites:
-        - [Python](https://docs.python.org/3/using/index.html)
-        - [Pip](https://pip.pypa.io/en/stable/installation/)
-2. configure pre-commit: `pre-commit install`
-3. install required tools
-    - [tflint](https://github.com/terraform-linters/tflint)
-    - [tfsec](https://aquasecurity.github.io/tfsec/v1.0.11/)
-    - [terraform-docs](https://github.com/terraform-docs/terraform-docs)
-    - [golang](https://go.dev/doc/install) (for macos you can use `brew`)
-    - [coreutils](https://www.gnu.org/software/coreutils/)
+## Usage
 
-Write code according to [I&A module standards](https://aws-ia.github.io/standards-terraform/)
+## Overview Diagrams
 
-## Module Documentation
-
-**Do not manually update README.md**. README.md is automatically generated by pulling in content from other files. For instructions, including a fill-in-the-blank content template, see [Create readmes for Terraform-based Partner Solutions.](https://aws-ia-us-west-2.s3.us-west-2.amazonaws.com/docs/content/index.html#/lessons/8rpYWWL59M7dcS-NsjYmaISUu-L_UqEv)
-
-## Terratest
-
-Please include tests to validate your examples/<> root modules, at a minimum. This can be accomplished with usually only slight modifications to the [boilerplate test provided in this template](./test/examples_basic_test.go)
-
-### Configure and run Terratest
-
-1. Install
-
-    [golang](https://go.dev/doc/install) (for macos you can use `brew`)
-2. Change directory into the test folder.
-
-    `cd test`
-3. Initialize your test
-
-    go mod init github.com/[github org]/[repository]
-
-    `go mod init github.com/aws-ia/terraform-aws-vpc`
-4. Run tidy
-
-    `go mod tidy`
-5. Install Terratest
-
-    `go get github.com/gruntwork-io/terratest/modules/terraform`
-6. Run test (You can have multiple test files).
-    - Run all tests
-
-        `go test`
-    - Run a specific test with a timeout
-
-        `go test -run TestExamplesBasic -timeout 45m`
-
-## Module Standards
-
-For best practices and information on developing with Terraform, see the [I&A Module Standards](https://aws-ia.github.io/standards-terraform/)
-
-## Continuous Integration
-
-The I&A team uses AWS CodeBuild to perform continuous integration (CI) within the organization. Our CI uses the a repo's `.pre-commit-config.yaml` file as well as some other checks. All PRs with other CI will be rejected. See our [FAQ](https://aws-ia.github.io/standards-terraform/faq/#are-modules-protected-by-ci-automation) for more details.
+## Terraform Module
diff --git a/README.md b/README.md
@@ -1,74 +1,24 @@
-# Creating modules for AWS I&A Organization
+# Terraform Module for AWS Shield Advanced
 
-This repo template is used to seed Terraform Module templates for the [AWS I&A GitHub organization](https://github.com/aws-ia). Usage of this template is allowed per included license. PRs to this template will be considered but are not guaranteed to be included. Consider creating an issue to discuss a feature you want to include before taking the time to create a PR.
+Terraform module that creates AWS Shield Advanced Resources
 
-<!-- markdownlint-disable MD001 -->
-### TL;DR
+- [Terraform Module for AWS Shield Advanced](#terraform-module-for-aws-shield-advanced)
+  - [Usage](#usage)
+  - [Overview Diagrams](#overview-diagrams)
+  - [Terraform Module](#terraform-module)
 
-1. [install pre-commit](https://pre-commit.com/#install)
-    - Prerequisites:
-        - [Python](https://docs.python.org/3/using/index.html)
-        - [Pip](https://pip.pypa.io/en/stable/installation/)
-2. configure pre-commit: `pre-commit install`
-3. install required tools
-    - [tflint](https://github.com/terraform-linters/tflint)
-    - [tfsec](https://aquasecurity.github.io/tfsec/v1.0.11/)
-    - [terraform-docs](https://github.com/terraform-docs/terraform-docs)
-    - [golang](https://go.dev/doc/install) (for macos you can use `brew`)
-    - [coreutils](https://www.gnu.org/software/coreutils/)
+## Usage
 
-Write code according to [I&A module standards](https://aws-ia.github.io/standards-terraform/)
+## Overview Diagrams
 
-## Module Documentation
-
-**Do not manually update README.md**. README.md is automatically generated by pulling in content from other files. For instructions, including a fill-in-the-blank content template, see [Create readmes for Terraform-based Partner Solutions.](https://aws-ia-us-west-2.s3.us-west-2.amazonaws.com/docs/content/index.html#/lessons/8rpYWWL59M7dcS-NsjYmaISUu-L_UqEv)
-
-## Terratest
-
-Please include tests to validate your examples/<> root modules, at a minimum. This can be accomplished with usually only slight modifications to the [boilerplate test provided in this template](./test/examples\_basic\_test.go)
-
-### Configure and run Terratest
-
-1. Install
-
-    [golang](https://go.dev/doc/install) (for macos you can use `brew`)
-2. Change directory into the test folder.
-
-    `cd test`
-3. Initialize your test
-
-    go mod init github.com/[github org]/[repository]
-
-    `go mod init github.com/aws-ia/terraform-aws-vpc`
-4. Run tidy
-
-    `go mod tidy`
-5. Install Terratest
-
-    `go get github.com/gruntwork-io/terratest/modules/terraform`
-6. Run test (You can have multiple test files).
-    - Run all tests
-
-        `go test`
-    - Run a specific test with a timeout
-
-        `go test -run TestExamplesBasic -timeout 45m`
-
-## Module Standards
-
-For best practices and information on developing with Terraform, see the [I&A Module Standards](https://aws-ia.github.io/standards-terraform/)
-
-## Continuous Integration
-
-The I&A team uses AWS CodeBuild to perform continuous integration (CI) within the organization. Our CI uses the a repo's `.pre-commit-config.yaml` file as well as some other checks. All PRs with other CI will be rejected. See our [FAQ](https://aws-ia.github.io/standards-terraform/faq/#are-modules-protected-by-ci-automation) for more details.
+## Terraform Module
 
 ### Requirements
 
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0.0 |
 | <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 4.47 |
-| <a name="requirement_random"></a> [random](#requirement\_random) | >= 3.4 |
 
 ### Providers
 
diff --git a/main.tf b/main.tf
@@ -34,7 +34,7 @@ resource "aws_shield_protection_group" "this" {
 # Health Check
 ##################################################
 resource "aws_route53_health_check" "this" {
-  for_each          = var.health_check_configuration
+  for_each          = var.health_check_configuration == null ? {} : var.health_check_configuration
   ip_address        = each.value.resource_ip
   port              = each.value.health_check_port
   type              = each.value.health_check_type
diff --git a/test/complete/main.tf b/test/complete/main.tf
@@ -0,0 +1,22 @@
+provider "aws" {}
+
+data "aws_region" "current" {}
+data "aws_caller_identity" "current" {}
+
+locals {
+  arn_prefix = "arn:aws:ec2:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:eip-allocation"
+}
+
+resource "aws_eip" "example" {
+  domain = "vpc"
+}
+
+module "shield_advanced" {
+  source = "../.."
+
+  name                = "Example protection"
+  resource_arn        = "${local.arn_prefix}/${aws_eip.example.id}"
+  protection_group_id = "example"
+  aggregation         = "MEAN"
+  pattern             = "ARBITRARY"
+}
diff --git a/test/complete/outputs.tf b/test/complete/outputs.tf
diff --git a/test/complete/variables.tf b/test/complete/variables.tf
diff --git a/test/complete/versions.tf b/test/complete/versions.tf
@@ -0,0 +1,10 @@
+terraform {
+  required_version = ">= 1.0.0"
+
+  required_providers {
+    aws = {
+      source  = "hashicorp/aws"
+      version = ">= 4.47"
+    }
+  }
+}
diff --git a/test/examples_basic_test.go b/test/examples_basic_test.go
diff --git a/variables.tf b/variables.tf
@@ -16,6 +16,14 @@ variable "protection_group_id" {
 variable "aggregation" {
   description = "Defines how AWS Shield combines resource data for the group in order to detect, mitigate, and report events."
   type        = string
+  validation {
+    condition = contains([
+      "SUM",
+      "MEAN",
+      "MAX",
+    ], var.aggregation)
+    error_message = "Valid values for `var.aggregation` are `SUM | MEAN | MAX`."
+  }
 }
 
 variable "pattern" {
diff --git a/versions.tf b/versions.tf
@@ -6,9 +6,5 @@ terraform {
       source  = "hashicorp/aws"
       version = ">= 4.47"
     }
-    random = {
-      source  = "hashicorp/random"
-      version = ">= 3.4"
-    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,5 @@ terraform {`
`6`	`6`	`source = "hashicorp/aws"`
`7`	`7`	`version = ">= 4.47"`
`8`	`8`	`}`
`9`		`- random = {`
`10`		`- source = "hashicorp/random"`
`11`		`- version = ">= 3.4"`
`12`		`- }`
`13`	`9`	`}`
`14`	`10`	`}`