Improve skipping parenthesis in arguments.

Author: kagg-design

WPForms/Sniffs/Comments/ParamTagHooksSniff.php

@@ -126,7 +126,7 @@ private function countArguments( $phpcsFile, $stackPtr ) { // phpcs:ignore Gener
 				continue;
 			}
 
-			if ( in_array( $tokens[ $currentPosition ]['code'], [ T_ARRAY, T_OPEN_SHORT_ARRAY ], true ) ) {
+			if ( in_array( $tokens[ $currentPosition ]['code'], [ T_ARRAY, T_OPEN_SHORT_ARRAY, T_CLOSURE ], true ) ) {
 				$quantity ++;
 			}
 
@@ -136,7 +136,7 @@ private function countArguments( $phpcsFile, $stackPtr ) { // phpcs:ignore Gener
 
 			$quantity ++;
 
-			$currentPosition = $phpcsFile->findNext( T_COMMA, $currentPosition + 1 );
+			$currentPosition = $phpcsFile->findNext( [ T_COMMA, T_ARRAY, T_OPEN_SHORT_ARRAY, T_OPEN_PARENTHESIS, T_OPEN_SQUARE_BRACKET, T_OPEN_CURLY_BRACKET ], $currentPosition + 1 );
 
 			if ( ! $currentPosition ) {
 				break;

WPForms/Tests/TestFiles/Comments/ParamTagHooks.php

@@ -66,26 +66,34 @@
  *
  * @since 1.3.0
  *
- * @param object $response Response data.
- * @param array $request_args Request arguments.
- * @param array $contact GetResponse contact data.
- * @param array $connection Connection data.
- * @param array $args Additional arguments.
+ * @param object $response     Response data.
+ * @param array  $request_args Request arguments.
+ * @param array  $contact      GetResponse contact data.
+ * @param array  $connection   Connection data.
+ * @param array  $args         Additional arguments.
+ * @param mixed  $arg6         Test argument.
+ * @param mixed  $arg7         Test argument.
+ * @param mixed  $arg8         Test argument.
+ * @param mixed  $arg9         Test argument.
+ * @param mixed  $arg10        Test argument.
+ * @param mixed  $arg11        Test argument.
+ * @param mixed  $arg12        Test argument.
+ * @param mixed  $arg13        Test argument.
  */
 do_action(
 	'wpforms_getresponse_provider_process_task_async_action_subscribe_after',
 	$response,
 	$request_args,
 	$contact,
 	$this->connection,
-	$this->connection[ $test ],
-	$this->connection(),
-	$this->connection( $a, $b, $c ),
 	[
 		'form_data' => $this->form_data,
 		'fields'    => $this->fields,
 		'entry'     => $this->entry,
 	],
+	$this->connection[ $test ],
+	$this->connection(),
+	$this->connection( $a, $b, $c ),
 	function () {
 		return 'true';
 	},
@@ -203,3 +211,27 @@ function () {
 
 /** This filter is documented in wp-includes/post-template.php */
 $content = apply_filters( 'the_content', $content );
+
+/**
+ * Allow modifying the text or url for the full page on the AMP pages.
+ *
+ * @since 1.4.1.1
+ * @since 1.7.1 Added $form_id, $full_page_url, and $form_data arguments.
+ *
+ * @param int   $form_id   Form id.
+ * @param array $form_data Form data and settings.
+ * @param array $form_data Form data and settings.
+ * @param array $form_data Form data and settings.
+ *
+ * @return string
+ */
+$text = (string) apply_filters(
+	'wpforms_frontend_shortcode_amp_text',
+	sprintf( /* translators: %s - URL to a non-amp version of a page with the form. */
+		__( '<a href="%s">Go to the full page</a> to view and submit the form.', 'wpforms-lite' ),
+		esc_url( $full_page_url )
+	),
+	$form_id,
+	$full_page_url,
+	$form_data
+);

WPForms/Tests/Tests/Comments/ParamTagHooksTest.php

@@ -22,9 +22,9 @@ public function testProcess() {
 		$phpcsFile = $this->process( new ParamTagHooksSniff() );
 
 		$this->fileHasErrors( $phpcsFile, 'InvalidAlign', [ 49, 50, 51, 52, 53 ] );
-		$this->fileHasErrors( $phpcsFile, 'InvalidParamTagsQuantity', [ 75 ] );
-		$this->fileHasErrors( $phpcsFile, 'MissParamInfo', [ 103, 104, 105, 106, 107, 108, 109 ] );
-		$this->fileHasErrors( $phpcsFile, 'AddStopSymbol', [ 133, 134, 138 ] );
-		$this->fileHasErrors( $phpcsFile, 'ExtraSpacesAfterParamTag', [ 160, 161, 162, 163, 164 ] );
+		$this->fileHasErrors( $phpcsFile, 'InvalidParamTagsQuantity', [] );
+		$this->fileHasErrors( $phpcsFile, 'MissParamInfo', [ 111, 112, 113, 114, 115, 116, 117 ] );
+		$this->fileHasErrors( $phpcsFile, 'AddStopSymbol', [ 141, 142, 146 ] );
+		$this->fileHasErrors( $phpcsFile, 'ExtraSpacesAfterParamTag', [ 168, 169, 170, 171, 172 ] );
 	}
 }