feat: allow host port to be configured via environment variable in Docker #65
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move dotenv config to the top of server.js - Update docker-compose.yml to properly handle .env file - Remove duplicate environment variables section This ensures BASE_PATH and TRUST_PROXY work as expected in both Docker and local environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR enhances the Docker setup to allow the host port to be configured dynamically.
The Problem
Currently, the
docker-compose.ymlfile has the host port hardcoded as3000in theportsmapping ("3000:3000").This becomes an issue in certain deployment environments (like Coolify, Dokploy, etc.) where the
docker-compose.ymlfile is often read-only. In such cases, users cannot easily change the host port if3000is already in use, as they can only modify environment variables.The Solution
This change updates the port mapping in
docker-compose.ymlto use an environment variable:This implementation:
$PORTenvironment variable for the host port.3000if the$PORTvariable is not set, ensuring backward compatibility for existing users.This provides greater flexibility for deploying the application without introducing any breaking changes.