#149|Added double method to fix casting issue.

Author: ramakanthk711

goonj/src/main/java/org/avni_integration_service/goonj/repository/DispatchReceiptRepository.java

@@ -29,6 +29,7 @@
 
 import static org.avni_integration_service.goonj.config.GoonjMappingDbConstants.MappingGroup_DispatchReceipt;
 import static org.avni_integration_service.goonj.config.GoonjMappingDbConstants.MappingType_Obs;
+import static org.avni_integration_service.goonj.util.NumberUtil.getDouble;
 
 @Component("DispatchReceiptRepository")
 public class DispatchReceiptRepository extends GoonjBaseRepository
@@ -109,13 +110,14 @@ public DispatchReceivedStatusLineItem createDispatchReceivedStatusLineItem(HashM
         String itemName = typeOfMaterial.equals(CONTRIBUTED_ITEM) ?
                 (String) entry.get(CONTRIBUTED_ITEM_NAME) :
                 (typeOfMaterial.equals(KIT) ? (String) entry.get(KIT_NAME) : (String) entry.get(MATERIAL_NAME));
-        double dispatchedQuantity = entry.get(QUANTITY_DISPATCHED) != null ?
-                (double) entry.get(QUANTITY_DISPATCHED) : 0d;
+        double dispatchedQuantity = getDouble(entry.get(QUANTITY_DISPATCHED)) != null ?
+                getDouble(entry.get(QUANTITY_DISPATCHED)) : 0d;
         boolean quantityMatching = entry.get(QUANTITY_MATCHING).equals("Yes");
         if (quantityMatching) {
             receivedQuantity = dispatchedQuantity;
         } else {
-            receivedQuantity = entry.get(QUANTITY) != null ? (double) entry.get(QUANTITY) : 0d;
+            receivedQuantity = getDouble(entry.get(QUANTITY)) != null ?
+                    getDouble(entry.get(QUANTITY)) : 0d;
         }
         return new DispatchReceivedStatusLineItem(dispatchStatusLineItemId, mapTypeOfMaterial(entry), itemName,
                 dispatchStatusLineItemId, EMPTY_STRING, EMPTY_STRING, dispatchedQuantity, receivedQuantity);

goonj/src/main/java/org/avni_integration_service/goonj/util/NumberUtil.java

@@ -7,4 +7,11 @@ public static Integer getInteger(Object value) {
         }
         return Double.valueOf(value.toString()).intValue();
     }
+
+    public static Double getDouble(Object value) {
+        if (value == null) {
+            return null;
+        }
+        return Double.valueOf(value.toString());
+    }
 }

goonj/src/main/java/org/avni_integration_service/goonj/worker/goonj/InventoryEventWorker.java

@@ -22,6 +22,8 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.avni_integration_service.goonj.util.NumberUtil.getDouble;
+
 @Component
 public class InventoryEventWorker extends GoonjEventWorker implements ErrorRecordWorker {
     private static final Logger logger = Logger.getLogger(InventoryEventWorker.class);
@@ -57,8 +59,8 @@ private void processImplementationInventory(Map<String, Object> inventoryRespons
         Subject subject = inventoryItems.subjectWithoutObservations();
         inventoryService.populateObservations(subject, inventoryItems);
         if (subject.getVoided() == Boolean.FALSE){
-            Object currentQuantity = subject.getObservation("Current Quantity");
-            if (currentQuantity != null && (Double) currentQuantity == 0d){
+            Double currentQuantity = getDouble(subject.getObservation("Current Quantity"));
+            if (currentQuantity != null && currentQuantity == 0d){
                 subject.setVoided(Boolean.TRUE);
                 logger.info(String.format("0 currentQuantity, Voiding implementation inventory: name %s || uuid %s", inventoryResponse.get("ImplementationInventoryName"), inventoryResponse.get("ImplementationInventoryId")));
             }

goonj/src/test/java/org/avni_integration_service/goonj/util/NumberUtilTest.java

@@ -3,10 +3,13 @@
 import org.avni_integration_service.util.ObjectJsonMapper;
 import org.junit.jupiter.api.Test;
 
+import java.util.HashMap;
 import java.util.Map;
 
+import static org.avni_integration_service.goonj.util.NumberUtil.getDouble;
 import static org.avni_integration_service.goonj.util.NumberUtil.getInteger;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public class NumberUtilTest {
 
@@ -24,4 +27,32 @@ public void shouldConvertToInteger() {
         assertEquals(getInteger(map.get("d")), null);
     }
 
+    @Test
+    public void shouldConvertToDouble() {
+        Map<String, Object> map = ObjectJsonMapper.readValue(
+                "{              \n" +
+                        "  \"a\": \"1\",    \n" +
+                        "  \"b\": 1,        \n" +
+                        "  \"c\": 1.5,      \n" +
+                        "  \"e\": \"1.2345\" \n" +
+                        "}", java.util.Map.class);
+
+        assertEquals(getDouble(map.get("a")), Double.valueOf(1.0));
+        assertEquals(getDouble(map.get("b")), Double.valueOf(1.0));
+        assertEquals(getDouble(map.get("c")), Double.valueOf(1.5));
+        assertEquals(getDouble(map.get("e")), Double.valueOf(1.2345));
+    }
+
+    @Test
+    public void shouldThrowClassCastExceptionWhenCastingIntegerToDouble() {
+        Map<String, Object> map = new HashMap<>();
+        map.put("value", Integer.valueOf(1));
+        map.put("value1", String.valueOf(1));
+        assertThrows(ClassCastException.class, () -> {
+            Double d = (Double) map.get("value");
+        });
+        assertThrows(ClassCastException.class, () -> {
+            Double d = (Double) map.get("value1");
+        });
+    }
 }