Skip to content

Commit 1f2e1e0

Browse files
committed
#691 - use ExceptionUtil to get full stack trace
1 parent 7dda432 commit 1f2e1e0

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

avni-server-api/src/main/java/org/avni/server/importer/batch/zip/ZipErrorFileWriterListener.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import org.avni.server.importer.batch.model.BundleFile;
44
import org.avni.server.service.BulkUploadS3Service;
5+
import org.avni.server.util.ExceptionUtil;
56
import org.slf4j.Logger;
67
import org.slf4j.LoggerFactory;
78
import org.springframework.batch.core.annotation.*;
@@ -54,9 +55,7 @@ public void onWriteError(Exception e, List o) {
5455

5556
public void writeError(BundleFile bundleFile, Throwable t) {
5657
try {
57-
String stackTrace = Stream.of(t.getStackTrace())
58-
.map(StackTraceElement::toString)
59-
.collect(Collectors.joining("\n"));
58+
String stackTrace = ExceptionUtil.getFullStackTrace(t);
6059
FileWriter fileWriter = new FileWriter(bulkUploadS3Service.getLocalErrorFile(uuid), true);
6160
fileWriter.append(bundleFile.getName());
6261
fileWriter.append(",\"");

avni-server-api/src/main/java/org/avni/server/util/ExceptionUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import java.io.StringWriter;
55

66
public class ExceptionUtil {
7-
public static String getFullStackTrace(Exception e) {
7+
public static String getFullStackTrace(Throwable e) {
88
StringWriter sw = new StringWriter();
99
PrintWriter pw = new PrintWriter(sw);
1010
e.printStackTrace(pw);

avni-server-api/src/test/java/org/avni/server/util/ExceptionUtilTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
import org.junit.Test;
44

5+
import java.util.stream.Collectors;
6+
import java.util.stream.Stream;
7+
58
import static org.junit.Assert.*;
69

710
public class ExceptionUtilTest {

0 commit comments

Comments
 (0)