Skip to content

Commit fb49860

Browse files
committed
updated with review comments
1 parent 812dcce commit fb49860

File tree

2 files changed

+10
-26
lines changed

2 files changed

+10
-26
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ jobs:
1212
build:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v3
1616

17-
- name: Setting up JDK21
18-
uses: actions/setup-java@v4
17+
- name: Setting up JDK8
18+
uses: actions/setup-java@v3
1919
with:
20-
java-version: '21'
21-
distribution: 'temurin'
20+
java-version: '8'
21+
distribution: 'adopt'
2222

2323
- name: Install Docker Compose
2424
run: |

pom.xml

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,11 @@
385385
<artifactId>maven-release-plugin</artifactId>
386386
<version>${maven-release-plugin.version}</version>
387387
</plugin>-->
388+
<plugin>
389+
<groupId>org.apache.maven.plugins</groupId>
390+
<artifactId>maven-surefire-plugin</artifactId>
391+
<version>${maven-surefire-plugin.version}</version>
392+
</plugin>
388393
<plugin>
389394
<groupId>org.apache.maven.plugins</groupId>
390395
<artifactId>maven-dependency-plugin</artifactId>
@@ -441,26 +446,5 @@
441446
</build>
442447
</profile>
443448

444-
<profile>
445-
<id>jdk-8</id>
446-
<activation>
447-
<jdk>1.8</jdk>
448-
</activation>
449-
<properties>
450-
<java.version>1.8</java.version>
451-
</properties>
452-
<build>
453-
<plugins>
454-
<plugin>
455-
<groupId>org.apache.maven.plugins</groupId>
456-
<artifactId>maven-surefire-plugin</artifactId>
457-
<version>${maven-surefire-plugin.version}</version>
458-
<configuration>
459-
<argLine>-Xmx512m</argLine>
460-
</configuration>
461-
</plugin>
462-
</plugins>
463-
</build>
464-
</profile>
465449
</profiles>
466450
</project>

0 commit comments

Comments
 (0)