fix deprecation warnings #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![augment-app-staging[bot]](https://avatars.githubusercontent.com/in/1008152?s=60&v=4){kind=small}
| end | ||
|
|
||
| client.notify(method, params) | ||
| client:notify(method, params) |
There was a problem hiding this comment.
Switching to client:notify(...) will pass the client table as the first argument, but Neovim’s LSP client client.notify is typically called with dot notation (client.notify(method, params)) and does not expect self; this can shift arguments and break the call. Consider keeping the dot call here.
🤖 React with 👍 or 👎 to let us know if the comment was useful.
| end | ||
|
|
||
| local _, id = client.request(method, params, function(err, result) | ||
| local _, id = client:request(method, params, function(err, result) |
There was a problem hiding this comment.
Similarly, client:request(...) will pass self and shift parameters; Neovim LSP usage expects client.request(method, params, handler, bufnr) with dot notation. This change is likely to cause request failures at runtime.
🤖 React with 👍 or 👎 to let us know if the comment was useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.