Disable guard-for-in

Author: efoken

.eslintrc

@@ -16,6 +16,7 @@
         "class-methods-use-this": "off",
         "consistent-return": "off",
         "eqeqeq": "off",
+        "guard-for-in": "off",
         "max-classes-per-file": "off",
         "new-cap": "off",
         "no-bitwise": "off",
@@ -25,6 +26,8 @@
         "no-continue": "off",
         "no-multi-assign": "off",
         "no-nested-ternary": "off",
+        "no-new-object": "off",
+        "no-object-constructor": "error",
         "no-param-reassign": "off",
         "no-plusplus": "off",
         "no-restricted-syntax": "off",

src/element/custom-element.js

@@ -47,9 +47,7 @@ export const c = (component, base) => {
                 this._setup();
                 this._render = () => component({ ...this._props });
                 for (const prop in values) {
-                    if (Object.prototype.hasOwnProperty.call(values, prop)) {
-                        this[prop] = values[prop];
-                    }
+                    this[prop] = values[prop];
                 }
             }
 
@@ -233,15 +231,13 @@ export const c = (component, base) => {
                 // @ts-ignore
                 const superAttrs = super.observedAttributes || [];
                 for (const prop in props) {
-                    if (Object.prototype.hasOwnProperty.call(props, prop)) {
-                        setPrototype(
-                            this.prototype,
-                            prop,
-                            props[prop],
-                            attrs,
-                            values,
-                        );
-                    }
+                    setPrototype(
+                        this.prototype,
+                        prop,
+                        props[prop],
+                        attrs,
+                        values,
+                    );
                 }
                 return Object.keys(attrs).concat(superAttrs);
             }

src/hooks/create-hooks.js

@@ -87,11 +87,9 @@ export const createHooks = (update, host, id = 0) => {
      */
     const cleanEffectsByType = (tag, unmounted) => {
         for (const index in hooks) {
-            if (Object.prototype.hasOwnProperty.call(hooks, index)) {
-                const hook = hooks[index];
-                if (hook.effect && hook.tag === tag) {
-                    hook.value = hook.effect(hook.value, unmounted);
-                }
+            const hook = hooks[index];
+            if (hook.effect && hook.tag === tag) {
+                hook.value = hook.effect(hook.value, unmounted);
             }
         }
     };

src/render.js

@@ -388,15 +388,11 @@ export function renderChildren(children, fragment, parent, id, hydrate, isSvg) {
  */
 export function diffProps(node, props, nextProps, handlers, isSvg) {
     for (const key in props) {
-        if (Object.prototype.hasOwnProperty.call(props, key)) {
-            !(key in nextProps) &&
-                setProperty(node, key, props[key], null, isSvg, handlers);
-        }
+        !(key in nextProps) &&
+            setProperty(node, key, props[key], null, isSvg, handlers);
     }
     for (const key in nextProps) {
-        if (Object.prototype.hasOwnProperty.call(nextProps, key)) {
-            setProperty(node, key, props[key], nextProps[key], isSvg, handlers);
-        }
+        setProperty(node, key, props[key], nextProps[key], isSvg, handlers);
     }
 }
 
@@ -460,11 +456,9 @@ export function setProperty(node, key, prevValue, nextValue, isSvg, handlers) {
 
         if (nextIsObject) {
             for (const key in nextValue) {
-                if (Object.prototype.hasOwnProperty.call(nextValue, key)) {
-                    const value = nextValue[key];
-                    if (prevIsObject && prevValue[key] === value) continue;
-                    setPropertyStyle(style, key, value);
-                }
+                const value = nextValue[key];
+                if (prevIsObject && prevValue[key] === value) continue;
+                setPropertyStyle(style, key, value);
             }
         } else {
             style.cssText = nextValue;

src/tests/internal/set-prototype.test.js

@@ -70,7 +70,7 @@ describe("internal: filterValue", () => {
             },
             {
                 type: Object,
-                // eslint-disable-next-line no-new-object
+                // eslint-disable-next-line no-object-constructor
                 success: [{}, new Object(), new (class {})()],
             },
             {

src/tests/render.test.js

@@ -159,9 +159,7 @@ describe("src/render", () => {
         );
 
         for (let key in attrs) {
-            if (Object.prototype.hasOwnProperty.call(attrs, key)) {
-                expect(el.getAttribute(key)).to.equal(attrs[key].expect);
-            }
+            expect(el.getAttribute(key)).to.equal(attrs[key].expect);
         }
     });
 

ssr/tag.js

@@ -26,33 +26,27 @@ export class Attributes {
     toString() {
         const attrs = new Map();
         for (let prop in this) {
-            if (Object.prototype.hasOwnProperty.call(this, prop)) {
-                const value = this[prop];
-                const type = typeof value;
+            const value = this[prop];
+            const type = typeof value;
 
-                if (
-                    INTERNAL_PROPS[prop] ||
-                    type === "function" ||
-                    prop[0] === "_"
-                )
-                    continue;
+            if (INTERNAL_PROPS[prop] || type === "function" || prop[0] === "_")
+                continue;
 
-                const attr =
-                    prop === "className"
-                        ? "class"
-                        : prop.replace(
-                              /([\w])([A-Z])/g,
-                              (all, before, after) =>
-                                  `${before}-${after.toLowerCase()}`,
-                          );
+            const attr =
+                prop === "className"
+                    ? "class"
+                    : prop.replace(
+                          /([\w])([A-Z])/g,
+                          (all, before, after) =>
+                              `${before}-${after.toLowerCase()}`,
+                      );
 
-                if (type === "boolean") {
-                    if (value) attrs.set(attr);
-                } else if (type === "object") {
-                    attrs.set(attr, JSON.stringify(value));
-                } else {
-                    attrs.set(attr, value);
-                }
+            if (type === "boolean") {
+                if (value) attrs.set(attr);
+            } else if (type === "object") {
+                attrs.set(attr, JSON.stringify(value));
+            } else {
+                attrs.set(attr, value);
             }
         }
         const list = [...attrs];