chore: fix some SA-rules

Author: davidkallesen

src/Atc.Rest.ApiGenerator.Framework/ContentGenerators/Server/ContentGeneratorServerConfigureSwaggerDocOptions.cs

@@ -245,16 +245,18 @@ private static string BuildStringLiteral(
         // Use verbatim if backslashes or newlines are present.
         if (text.IndexOfAny(new[] { '\\', '\r', '\n' }) >= 0)
         {
-            var verbatim = text.Replace("\"", "\"\"");
+            var verbatim = text.Replace("\"", "\"\"", StringComparison.Ordinal);
             return "@\"" + verbatim + "\"";
         }
 
         // Otherwise, use a normal C# string literal.
-        var normal = text.Replace("\\", "\\\\").Replace("\"", "\\\"");
+        var normal = text
+            .Replace("\\", "\\\\", StringComparison.Ordinal)
+            .Replace("\"", "\\\"", StringComparison.Ordinal);
         return "\"" + normal + "\"";
     }
 
     private static bool Has(
         string? s)
         => !string.IsNullOrWhiteSpace(s);
-}
+}

src/Atc.Rest.ApiGenerator.OpenApi/Extensions/OpenApiAnyExtensions.cs

@@ -4,15 +4,41 @@ public static class OpenApiAnyExtensions
 {
     /// <summary>
     /// Returns a string representation of common OpenAPI primitives with predictable, culture-fixed formatting.
-    /// Notes:
-    ///  - Booleans -> "true"/"false" (lowercase JSON style).
-    ///  - Date -> "yyyy-MM-dd" (e.g., 2025-09-03), culture-fixed to avoid month/day swaps.
-    ///  - DateTime -> ISO 8601 round-trip "O" (e.g., 2025-09-03T12:34:56.7890123+00:00).
-    ///  - Double/Float -> "N" using en-US (group separators + decimals; e.g., 1,234.00).
-    ///  - Long/Integer -> default numeric ("G") with en-US (no group separators, no decimals; e.g., 1234).
-    ///  - Null -> "null" literal.
-    ///  - String/Password -> empty -> "string.Empty"; otherwise the raw value (unquoted).
     /// </summary>
+    /// <remarks>
+    /// <para>Formatting rules:</para>
+    /// <list type="bullet">
+    ///   <item><description><b>Booleans</b> → <c>"true"</c>/<c>"false"</c> (lowercase JSON style).</description></item>
+    ///   <item><description><b>Date</b> → <c>"yyyy-MM-dd"</c> (e.g., <c>2025-09-03</c>), culture-fixed to avoid month/day swaps.</description></item>
+    ///   <item><description><b>DateTime</b> → ISO 8601 round-trip <c>"O"</c> (e.g., <c>2025-09-03T12:34:56.7890123+00:00</c>).</description></item>
+    ///   <item><description><b>Double/Float</b> → standard numeric format <c>"N"</c> using en-US (group separators + decimals; e.g., <c>1,234.00</c>).</description></item>
+    ///   <item><description><b>Long/Integer</b> → general numeric format <c>"G"</c> using en-US (no group separators, no decimals; e.g., <c>1234</c>).</description></item>
+    ///   <item><description><b>Null</b> → the literal <c>"null"</c>.</description></item>
+    ///   <item><description><b>String/Password</b> → empty → <c>"string.Empty"</c>; otherwise the raw value (unquoted).</description></item>
+    /// </list>
+    /// <para>
+    /// Culture is fixed to <see cref="GlobalizationConstants.EnglishCultureInfo"/> (en-US) to ensure consistent output across environments.
+    /// </para>
+    /// </remarks>
+    /// <param name="openApiAny">The <see cref="IOpenApiAny"/> value to format (e.g., <see cref="OpenApiBoolean"/>, <see cref="OpenApiDate"/>, <see cref="OpenApiDateTime"/>, <see cref="OpenApiDouble"/>, <see cref="OpenApiFloat"/>, <see cref="OpenApiLong"/>, <see cref="OpenApiInteger"/>, <see cref="OpenApiNull"/>, <see cref="OpenApiPassword"/>, <see cref="OpenApiString"/>).</param>
+    /// <returns>
+    /// The formatted string representation of <paramref name="openApiAny"/>; <see langword="null"/> if <paramref name="openApiAny"/> is <see langword="null"/>.
+    /// </returns>
+    /// <exception cref="NotImplementedException">
+    /// Thrown when <paramref name="openApiAny"/> is an <see cref="IOpenApiAny"/> subtype not handled by this method.
+    /// </exception>
+    /// <example>
+    /// <code>
+    /// IOpenApiAny v1 = new OpenApiDouble(1234);
+    /// string? s1 = v1.GetDefaultValueAsString(); // "1,234.00"
+    ///
+    /// IOpenApiAny v2 = new OpenApiDate(new DateOnly(2025, 9, 3));
+    /// string? s2 = v2.GetDefaultValueAsString(); // "2025-09-03"
+    ///
+    /// IOpenApiAny v3 = new OpenApiString(string.Empty);
+    /// string? s3 = v3.GetDefaultValueAsString(); // "string.Empty"
+    /// </code>
+    /// </example>
     public static string? GetDefaultValueAsString(
         this IOpenApiAny? openApiAny)
     {

src/Atc.Rest.ApiGenerator.OpenApi/Extensions/OpenApiParameterExtensions.cs

@@ -47,7 +47,9 @@ public static bool ContainsEnumInSchemaOrProperties(
         var defaultValueInitializer = openApiParameter.Schema.GetDefaultValueAsString();
 
         if (!string.IsNullOrEmpty(defaultValueInitializer) &&
-            openApiParameter.ContainsEnumInSchemaOrProperties())
+            openApiParameter.ContainsEnumInSchemaOrProperties() &&
+            dataType != "long" &&
+            dataType != "string")
         {
             defaultValueInitializer = dataType.Equals(parameterName, StringComparison.Ordinal)
                 ? $"{contractNamespaceWithoutApiGroupName}.{dataType}.{defaultValueInitializer.PascalCase(ApiOperationExtractor.ModelNameSeparators, removeSeparators: true)}"

src/Atc.Rest.ApiGenerator.OpenApi/Extractors/ApiOperationExtractor.cs

@@ -168,9 +168,9 @@ private static void CollectSchema(
                     httpOperation,
                     parentApiSchema,
                     result);
-            }
 
-            return;
+                return;
+            }
         }
 
         (var schemaKey, apiSchema) = ConsolidateSchemaObjectTypes(apiSchema);

test/Atc.Rest.ApiGenerator.CLI.Tests/Scenarios/Monta/VerifyClient/WCEM/src/Monta.ApiClient.Generated/Contracts/_Shared/Pricing.verified.cs

@@ -57,7 +57,7 @@ public class Pricing
     /// <summary>
     /// Used by Spot Price. It will multiply the fallback price by this percentage.
     /// </summary>
-    public double? Percentage { get; set; }
+    public float? Percentage { get; set; }
 
     /// <summary>
     /// The id of the selected Tariff.