Skip to content

Commit d1684b0

Browse files
authored
limit test-embed patch to Python 3.12 and 3.13 (#918)
A version of `patch-test-embed-prevent-segfault.patch` was merged upstream in python/cpython#128474. It is not needed in CPython 3.14+
1 parent 0d07a8b commit d1684b0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cpython-unix/build-cpython.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,8 +284,8 @@ fi
284284
# BOLT instrumented binaries segfault in some test_embed tests for unknown reasons.
285285
# On 3.12 (minimum BOLT version), the segfault causes the test harness to
286286
# abort and BOLT optimization uses the partial test results. On 3.13, the segfault
287-
# is a fatal error.
288-
if [ -n "${PYTHON_MEETS_MINIMUM_VERSION_3_12}" ]; then
287+
# is a fatal error. Fixed in 3.14+, https://github.com/python/cpython/pull/128474
288+
if [ "${PYTHON_MAJMIN_VERSION}" = 3.12 ] || [ "${PYTHON_MAJMIN_VERSION}" = 3.13 ]; then
289289
patch -p1 -i ${ROOT}/patch-test-embed-prevent-segfault.patch
290290
fi
291291

0 commit comments

Comments
 (0)