Skip to content

Commit d4e3d04

Browse files
committed
Add metadata escaping
1 parent c383a0e commit d4e3d04

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

pom.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>com.assertthat.plugins</groupId>
77
<artifactId>assertthat-bdd-standalone</artifactId>
8-
<version>1.8</version>
8+
<version>1.9</version>
99
<name>assertthat-bdd-standalone</name>
1010
<description>AssertThat BDD Jira plugin client standalone</description>
1111
<url>http://www.assertthat.com</url>
@@ -71,6 +71,11 @@
7171
<artifactId>jettison</artifactId>
7272
<version>1.4.0</version>
7373
</dependency>
74+
<dependency>
75+
<groupId>com.google.guava</groupId>
76+
<artifactId>guava</artifactId>
77+
<version>23.0</version>
78+
</dependency>
7479
</dependencies>
7580

7681
<build>

src/main/java/com/assertthat/plugins/internal/APIUtil.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.assertthat.plugins.internal;
22

3+
import com.google.common.net.UrlEscapers;
34
import com.sun.jersey.api.client.*;
45
import com.sun.jersey.api.client.config.DefaultClientConfig;
56
import com.sun.jersey.api.client.filter.ClientFilter;
@@ -152,10 +153,7 @@ public Long upload(Long runId, String runName, String filePath, String type, Str
152153
queryParams.add("runId", runId.toString());
153154
queryParams.add("type", type);
154155
if(metadata!=null) {
155-
queryParams.add("metadata", URLEncoder.encode(metadata, StandardCharsets.UTF_8.toString()));
156-
System.err.println(URLEncoder.encode(metadata, StandardCharsets.UTF_8.toString()));
157-
System.err.println(runName);
158-
156+
queryParams.add("metadata", UrlEscapers.urlFragmentEscaper().escape(metadata));
159157
}
160158
client.addFilter(new ClientFilter() {
161159
@Override

0 commit comments

Comments
 (0)