Skip to content

Commit 0c867f8

Browse files
committed
Fix passing numbered parameter
1 parent fd999d1 commit 0c867f8

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>com.assertthat.plugins</groupId>
77
<artifactId>assertthat-bdd-standalone</artifactId>
8-
<version>1.9.2</version>
8+
<version>1.9.3</version>
99
<name>assertthat-bdd-standalone</name>
1010
<description>AssertThat BDD Jira plugin client standalone</description>
1111
<url>http://www.assertthat.com</url>

src/main/java/com/assertthat/plugins/api/Main.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,10 @@ public static void main(String[] args) throws IOException, JSONException {
158158
formatter.printHelp("assertthat-bdd-standalone-1.3.jar", options);
159159
System.exit(0);
160160
}
161-
161+
boolean isNumbered = true;
162+
if(cmd.hasOption("numbered") && cmd.getOptionValue("numbered") !=null && cmd.getOptionValue("numbered").equals("false")){
163+
isNumbered = false;
164+
}
162165
Arguments arguments = new Arguments(
163166
cmd.getOptionValue("accessKey"),
164167
cmd.getOptionValue("secretKey"),
@@ -175,7 +178,7 @@ public static void main(String[] args) throws IOException, JSONException {
175178
cmd.getOptionValue("tags"),
176179
cmd.getOptionValue("type"),
177180
cmd.getOptionValue("jiraServerUrl"),
178-
cmd.getOptionValue("numbered")
181+
isNumbered
179182
);
180183

181184
APIUtil apiUtil = new APIUtil(arguments.getProjectId(), arguments.getAccessKey(), arguments.getSecretKey(), arguments.getProxyURI(), arguments.getProxyUsername(), arguments.getProxyPassword(), arguments.getJiraServerUrl());

src/main/java/com/assertthat/plugins/internal/APIUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ public File download(File targetDir, String mode, String jql,
119119
if (jql != null) {
120120
queryParams.add("jql", jql.trim());
121121
}
122-
queryParams.add("numbered", isNumbered);
122+
queryParams.add("numbered", String.valueOf(isNumbered));
123123
client.addFilter(new ClientFilter() {
124124
@Override
125125
public ClientResponse handle(ClientRequest

src/main/java/com/assertthat/plugins/internal/Arguments.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public Arguments(String accessKey,
6060
String tags,
6161
String type,
6262
String jiraServerUrl,
63-
String numbered) {
63+
boolean numbered) {
6464
this.accessKey = System.getenv("ASSERTTHAT_ACCESS_KEY");
6565
this.secretKey = System.getenv("ASSERTTHAT_SECRET_KEY");
6666
if (accessKey != null && !accessKey.trim().isEmpty()) {
@@ -78,7 +78,7 @@ public Arguments(String accessKey,
7878
this.proxyPassword = proxyPassword;
7979
this.proxyUsername = proxyUsername;
8080
this.jiraServerUrl = jiraServerUrl;
81-
this.numbered = numbered == null || numbered.equals("true");
81+
this.numbered = numbered;
8282

8383
if (runName != null) {
8484
this.runName = runName;
@@ -116,7 +116,7 @@ public Arguments(String accessKey,
116116
String type,
117117
String jiraServerUrl,
118118
String metadata,
119-
String numbered) {
119+
boolean numbered) {
120120
this(accessKey, secretKey, projectId, runName, outputFolder, jsonReportFolder, jsonReportIncludePattern, proxyURI, proxyUsername, proxyPassword, mode, jql, tags, type, jiraServerUrl, numbered);
121121
this.metadata = metadata;
122122

0 commit comments

Comments
 (0)