do not build query filter with or: [] when all records are successfully upserted, for return_skipped_upsert?: true #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using Ash.bulk_create/4 with the AshPostgres data layer, upsert?: true, and return_skipped_upsert?: true, if all records are successfully inserted (none skipped due to upsert conditions), the code builds a filter with or: [] to fetch skipped records, which triggers a crash:
Contributor checklist
Leave anything that you believe does not apply unchecked.