[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-04-01-preview (Azure#14137)

susolank · Andrew Sager · commit e3db323539c2 · 2021-06-24T13:39:30.000-04:00
* Support release key permission for vault access policies

* Remove 400 and 409 error codes from response object

* Fix model validation issues

* Remove extra 400 from deleted vault response
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVault.json
@@ -265,24 +265,6 @@
           "provisioningState": "Succeeded"
         }
       }
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVaultWithNetworkAcls.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVaultWithNetworkAcls.json
@@ -127,24 +127,6 @@
           "vaultUri": "https://sample-vault.vault.azure.net"
         }
       }
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/deleteVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/deleteVault.json
@@ -11,15 +11,6 @@
     },
     "204": {
       "headers": {}
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json
@@ -12,15 +12,6 @@
     "202": {
       "headers": {}
     },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
     "404": {
       "headers": {},
       "body": {
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json
@@ -78,15 +78,6 @@
         }
       }
     },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
     "404": {
       "headers": {},
       "body": {
@@ -95,15 +86,6 @@
           "message": ""
         }
       }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateVault.json
@@ -263,24 +263,6 @@
           "provisioningState": "Succeeded"
         }
       }
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json
@@ -63,20 +63,6 @@
               "$ref": "#/definitions/Vault"
             }
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
-          "409": {
-            "description": "A conflict occurred to prevent the operation from completing.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -150,20 +136,6 @@
               "$ref": "#/definitions/Vault"
             }
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
-          "409": {
-            "description": "A conflict occurred to prevent the operation from completing.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -218,13 +190,6 @@
           "204": {
             "description": "No Content."
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -367,27 +332,13 @@
               "$ref": "#/definitions/VaultAccessPolicyParameters"
             }
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "404": {
             "description": "The specified resource does not exist.",
             "schema": {
               "$ref": "common.json#/definitions/CloudError"
             },
             "x-ms-error-response": true
           },
-          "409": {
-            "description": "A conflict occurred to prevent the operation from completing.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -657,13 +608,6 @@
           "202": {
             "description": "Vault is being purged."
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "404": {
             "description": "The specified resource does not exist.",
             "schema": {
@@ -1171,7 +1115,8 @@
               "backup",
               "restore",
               "recover",
-              "purge"
+              "purge",
+              "release"
             ],
             "x-ms-enum": {
               "name": "KeyPermissions",

Original file line number	Diff line number	Diff line change
`@@ -265,24 +265,6 @@`
`265`	`265`	`"provisioningState": "Succeeded"`
`266`	`266`	`}`
`267`	`267`	`}`
`268`		`- },`
`269`		`- "400": {`
`270`		`- "headers": {},`
`271`		`- "body": {`
`272`		`- "error": {`
`273`		`- "code": "",`
`274`		`- "message": ""`
`275`		`- }`
`276`		`- }`
`277`		`- },`
`278`		`- "409": {`
`279`		`- "headers": {},`
`280`		`- "body": {`
`281`		`- "error": {`
`282`		`- "code": "",`
`283`		`- "message": ""`
`284`		`- }`
`285`		`- }`
`286`	`268`	`}`
`287`	`269`	`}`
`288`	`270`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,24 +127,6 @@`
`127`	`127`	`"vaultUri": "https://sample-vault.vault.azure.net"`
`128`	`128`	`}`
`129`	`129`	`}`
`130`		`- },`
`131`		`- "400": {`
`132`		`- "headers": {},`
`133`		`- "body": {`
`134`		`- "error": {`
`135`		`- "code": "",`
`136`		`- "message": ""`
`137`		`- }`
`138`		`- }`
`139`		`- },`
`140`		`- "409": {`
`141`		`- "headers": {},`
`142`		`- "body": {`
`143`		`- "error": {`
`144`		`- "code": "",`
`145`		`- "message": ""`
`146`		`- }`
`147`		`- }`
`148`	`130`	`}`
`149`	`131`	`}`
`150`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,15 +11,6 @@`
`11`	`11`	`},`
`12`	`12`	`"204": {`
`13`	`13`	`"headers": {}`
`14`		`- },`
`15`		`- "400": {`
`16`		`- "headers": {},`
`17`		`- "body": {`
`18`		`- "error": {`
`19`		`- "code": "",`
`20`		`- "message": ""`
`21`		`- }`
`22`		`- }`
`23`	`14`	`}`
`24`	`15`	`}`
`25`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,15 +78,6 @@`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`	`},`
`81`		`- "400": {`
`82`		`- "headers": {},`
`83`		`- "body": {`
`84`		`- "error": {`
`85`		`- "code": "",`
`86`		`- "message": ""`
`87`		`- }`
`88`		`- }`
`89`		`- },`
`90`	`81`	`"404": {`
`91`	`82`	`"headers": {},`
`92`	`83`	`"body": {`
`@@ -95,15 +86,6 @@`
`95`	`86`	`"message": ""`
`96`	`87`	`}`
`97`	`88`	`}`
`98`		`- },`
`99`		`- "409": {`
`100`		`- "headers": {},`
`101`		`- "body": {`
`102`		`- "error": {`
`103`		`- "code": "",`
`104`		`- "message": ""`
`105`		`- }`
`106`		`- }`
`107`	`89`	`}`
`108`	`90`	`}`
`109`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -263,24 +263,6 @@`
`263`	`263`	`"provisioningState": "Succeeded"`
`264`	`264`	`}`
`265`	`265`	`}`
`266`		`- },`
`267`		`- "400": {`
`268`		`- "headers": {},`
`269`		`- "body": {`
`270`		`- "error": {`
`271`		`- "code": "",`
`272`		`- "message": ""`
`273`		`- }`
`274`		`- }`
`275`		`- },`
`276`		`- "409": {`
`277`		`- "headers": {},`
`278`		`- "body": {`
`279`		`- "error": {`
`280`		`- "code": "",`
`281`		`- "message": ""`
`282`		`- }`
`283`		`- }`
`284`	`266`	`}`
`285`	`267`	`}`
`286`	`268`	`}`