Skip to content

Commit 1cdc576

Browse files
committed
Update README Codestyle 📚
1 parent 9c80164 commit 1cdc576

File tree

1 file changed

+25
-24
lines changed

1 file changed

+25
-24
lines changed

README.md

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,10 @@ but there is another solution with the same number of packs:
3636
```
3737

3838
The only difference is price. So I assume, that I need to:
39-
* find solution **min by number of packs,** if there are solutions with **the same number of packs:**
40-
* find among them solution **max by total price,** if there are solutions with **the same price:**
41-
* choose any of them.
39+
40+
- find solution **min by number of packs,** if there are solutions with **the same number of packs:**
41+
- find among them solution **max by total price,** if there are solutions with **the same price:**
42+
- choose any of them.
4243

4344
### Production: benchmarks etc.
4445

@@ -130,7 +131,7 @@ empty code, empty name, empty price, empty count etc.
130131

131132
A bakery used to base the price of their produce on an individual item cost. So if a customer ordered 10 cross buns then they would be charged 10x the cost of a single bun. The bakery has decided to start selling their produce prepackaged in bunches and charging the customer on a per pack basis. So if the shop sold vegemite scroll in packs of 3 and 5 and a customer ordered 8 they would get a pack of 3 and a pack of 5. The bakery currently sells the following products:
132133

133-
| Name | Code | Packs |
134+
| Name | Code | Packs |
134135
| ---------------- | ---- | ------------------------------------- |
135136
| Vegemite Scroll | VS5 | 3 @ $6.99<br>5 @ $8.99 |
136137
| Blueberry Muffin | MB11 | 2 @ $9.95<br>5 @ $16.95<br>8 @ $24.95 |
@@ -169,26 +170,26 @@ A successfully passing test(s) that demonstrates the following output:
169170

170171
#### Advice:
171172

172-
* Choose whatever language you're comfortable with
173-
* The input/output format is not important, do whatever feels reasonable
174-
* Make sure you include at least one test
175-
* We expect the see code which you would be happy to put in production
176-
* If something is not clear don't hesitate to ask or just make an assumption and go with it
173+
- Choose whatever language you're comfortable with
174+
- The input/output format is not important, do whatever feels reasonable
175+
- Make sure you include at least one test
176+
- We expect the see code which you would be happy to put in production
177+
- If something is not clear don't hesitate to ask or just make an assumption and go with it
177178

178179
#### CodingTaskCriteria
179180

180-
* Is the code functional:
181-
* Are there instructions to setup/install?
182-
* Does it meet the minimum requirements in the specification?
183-
* Does it return appropriate results in other circumstances?
184-
* Is the code readable:
185-
* Sensible naming of variables and methods?
186-
* Sensible method sizes (<20 lines)?
187-
* Low complexity methods?
188-
* Is the code tested:
189-
* Unit tests for at least major classes?
190-
* End to end functional or integration tests?
191-
* Is the design sound:
192-
* Is it object oriented?
193-
* Does it follow the Single Responsibility Principle?
194-
* Does it follow the Law of Demeter?
181+
- Is the code functional:
182+
- Are there instructions to setup/install?
183+
- Does it meet the minimum requirements in the specification?
184+
- Does it return appropriate results in other circumstances?
185+
- Is the code readable:
186+
- Sensible naming of variables and methods?
187+
- Sensible method sizes (<20 lines)?
188+
- Low complexity methods?
189+
- Is the code tested:
190+
- Unit tests for at least major classes?
191+
- End to end functional or integration tests?
192+
- Is the design sound:
193+
- Is it object oriented?
194+
- Does it follow the Single Responsibility Principle?
195+
- Does it follow the Law of Demeter?

0 commit comments

Comments
 (0)