Skip to content

Several code updates #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Several code updates #5

wants to merge 64 commits into from

Conversation

@dsacc
Copy link

@dsacc dsacc commented Oct 1, 2017

PR features:

  • Fix style according to PEP8
  • Add comments
  • Add support for Python 2.7
  • Add compatibility with NetworkX 2.0
  • Improve reproducibility of experiments
  • Add doctest to compression_experiment
  • Add Travis CI
  • Faster Hammond Wavelet Transform
  • Remove unused/undocumented functions
  • Remove unused variables, arguments, and attributes

Setting seeds, using 'tracemin_lu' instead of 'lobpcg', and setting PYTHONHASHSEED to a constant value, the results seem exactly the same of those at your latest commit.

diego-sacconi added 30 commits August 28, 2017 12:41
Add .gitignore
610a7b8
Remove beta from sweep_opt arguments
4d3bbc6
Move sqrtm to graph_signal_proc.py
12919f2
Add info to dataset.py
f67c75c
Clean optimal_cut imports
dce1911
Remove unintentional comment
6771cd2
Clean graph_signal_proc imports
2c5b1b9
Fix some doc in graph_signal_proc
dd5b6e5
Fix incoherent use of arg N of graph_low_pass
311c3d2
Update graph_low_pass and graph_wavelets
e9c6ed5
Fix graph_fourier and graph_fourier_inverse
31f96af
Add comment to Hammond's transform and inverse
4a07252
Update comments in partitions_level_rec
dcbd242
Remove create_linked_list
5f2b1e9
Clean the sweep function
08b5d98
Remove arg in graph_low_pass
c748441
Remove for loop in graph_low_pass
9d0b9bf
Remove for loop in graph_wavelets
d5eec50
Fix doc in lib/graph_signal_proc.py
1f91edb
Remove attributes from Node object
2ec310c
Clean code in graph_signal_proc.py
e7d271d
Fix imports and style in lib/syn.py
8ee07a8
Add seeds as args for functions in syn.py
78435e8
Set seeds in synthetic-data for reproducibility
0797289
Set seeds in synthetic-data for reproducibility
68e83b0
Fix imports in lib/experiments.py
54b9117
Remove not used vars in lib/experiments.py
618481c
Make graph_signal_proc and optimal_cut slimmer
cfbc481
Make graph_signal_proc and optimal_cut slimmer
78081b0
Fix imports in lib/static.py
34de5f0
diego-sacconi added 29 commits September 7, 2017 16:41
Clean compression-experiments.ipynb
c7e5058
Clean synthetic-data.ipynb
5441ccb
Review code for ratio_cut_hierarchy
1491ec2
Remove avgs and counts attributes from Node
fa099ac
Review code for Gavish tranform
6a1ff2b
Remove unused functions from io.py
e262f03
Review comments in io.py
093c8bd
Clean code for sweep_opt
4413882
Update README.md
e07d731
Make fast_cac faster
c4c764a
Merge branch 'slim' of https://github.com/diego-sacconi/sparse-wavelets…
1b74e09 
… into slim
Review code for fast_cac
d878cbd
Clean code in lib/syn.py
3c72ac4
Add DOCTEST to compression_experiment
a5a5c61
Merge branch 'slim'
53db7ee
Update README.md
3836f1a
Update README.md
8c4ee9b
Group notebooks in a folder
ba7bc19
Remove redundant notebook
65cc719
Update compression-experiments.ipynb and figures
141ade6
Add lib/__init__.py
7633db4
Add comments
0198bee
Rename lib/io to lib/io_utils and make minor changes
8fa4d91
Add compatibility for NetworkX 2.0
4104303
Update lib/io_utils.py
4d6bc5f
Add Travis CI
310f9b1
Add info for testing
2d03f97
Add support for Python 2.7
7d1f94b
Fix style and add comments to lib/vis.py
d25c5f3
@dsacc dsacc changed the title Several code updates - see the comment Several code updates Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dsacc