Fix options rendering in APTConfigLine breaking its output #17
Conversation
Without that added space, the line generated is actually invalid. Take for instance Docker's apt repository: parsing its apt config line `deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable` will yield a well-formed repository. However, re-generating the line with APTConfigLine from that Repository will yield `deb [signed-by=/etc/apt/keyrings/docker.asc]https://download.docker.com/linux/debian bookworm stable` (note the missing space). This will result in errors such as: ``` Error: Malformed entry 1 in list file /etc/apt/sources.list.d/stable.list ([option] not assignment) Error: The list of sources could not be read. ```
|
@per1234 given that this is a bug, would you be open to review this PR? I suspect the other enhancements I've opened can wait but without this fix I think any repository addition with an option actually breaks. |
|
Hi @mickael-carl. Thanks so much for your contributions, and for your offer to assist in the maintenance! I only act in a janitorial role in this project, without any involvement in the development. So unfortunately I am not able to provide code reviews, merge PRs, or make decisions regarding project management. |
|
@per1234 thanks for the quick response! Would you happen to know who I could contact for assistance? |
|
@cmaglie maybe? |
2 participants
Without that added space, the line generated is actually invalid. Take for instance Docker's apt repository: parsing its apt config line
deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stablewill yield a well-formed repository. However, re-generating the line with APTConfigLine from that Repository will yielddeb [signed-by=/etc/apt/keyrings/docker.asc]https://download.docker.com/linux/debian bookworm stable(note the missing space). This will result in errors such as: