Enforce awaitPacket behaviour on unit tests

Author: cmaglie

network-api/network-api.go

@@ -568,7 +568,7 @@ func udpRead(ctx context.Context, rpc *msgpackrpc.Connection, params []any) (_re
 			udpReadBuffers[id] = buffer[maxBytes:]
 			n = maxBytes
 		} else {
-			udpReadBuffers[id] = nil
+			delete(udpReadBuffers, id)
 		}
 	}
 	lock.Unlock()

network-api/network-api_test.go

@@ -297,11 +297,14 @@ func TestUDPNetworkAPI(t *testing.T) {
 		require.Nil(t, err)
 		require.Equal(t, []any{3, "127.0.0.1", 9800}, res)
 
-		res2, err := udpRead(ctx, nil, []any{conn2, 100})
+		// A partial read of a packet is allowed
+		res2, err := udpRead(ctx, nil, []any{conn2, 2})
 		require.Nil(t, err)
-		require.Equal(t, []uint8("One"), res2)
+		require.Equal(t, []uint8("On"), res2)
 	}
 	{
+		// Even if the previous packet was only partially read,
+		// the next packet can be received
 		res, err := udpAwaitPacket(ctx, nil, []any{conn2})
 		require.Nil(t, err)
 		require.Equal(t, []any{3, "127.0.0.1", 9800}, res)