refacto: rename @pipelines->@core, optim->optimizer, explicitly instanciate pipeline in train configs

percevalw · percevalw · commit e5b6afcdf8d7 · 2024-11-14T10:08:04.000+01:00
diff --git a/edsnlp/training/trainer.py b/edsnlp/training/trainer.py
@@ -484,9 +484,9 @@ def train(
                     )
                 )
             )
-            if hasattr(optim, "initialize"):
-                optim.initialize()
             (accel_optim, *trained_pipes) = accelerator.prepare(optim, *trained_pipes)
+            if hasattr(accel_optim.optimizer, "initialize"):
+                accel_optim.optimizer.initialize()
 
             cumulated_data = defaultdict(lambda: 0.0, count=0)
             all_metrics = []

Original file line number	Diff line number	Diff line change
`@@ -484,9 +484,9 @@ def train(`
`484`	`484`	`)`
`485`	`485`	`)`
`486`	`486`	`)`
`487`		`- if hasattr(optim, "initialize"):`
`488`		`- optim.initialize()`
`489`	`487`	`(accel_optim, trained_pipes) = accelerator.prepare(optim, trained_pipes)`
	`488`	`+ if hasattr(accel_optim.optimizer, "initialize"):`
	`489`	`+ accel_optim.optimizer.initialize()`
`490`	`490`
`491`	`491`	`cumulated_data = defaultdict(lambda: 0.0, count=0)`
`492`	`492`	`all_metrics = []`