fix: response future should close channel before callback (#1113)

twz915 · web-flow · commit 3f9c59fdf5d4 · 2023-12-04T11:13:16.000+08:00
diff --git a/internal/remote/remote_client.go b/internal/remote/remote_client.go
@@ -231,10 +231,10 @@ func (c *remotingClient) processCMD(cmd *RemotingCommand, r *tcpConnWrapper) {
 			responseFuture := resp.(*ResponseFuture)
 			go primitive.WithRecover(func() {
 				responseFuture.ResponseCommand = cmd
-				responseFuture.executeInvokeCallback()
 				if responseFuture.Done != nil {
 					close(responseFuture.Done)
 				}
+				responseFuture.executeInvokeCallback()
 			})
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -231,10 +231,10 @@ func (c remotingClient) processCMD(cmd RemotingCommand, r *tcpConnWrapper) {`
`231`	`231`	`responseFuture := resp.(*ResponseFuture)`
`232`	`232`	`go primitive.WithRecover(func() {`
`233`	`233`	`responseFuture.ResponseCommand = cmd`
`234`		`- responseFuture.executeInvokeCallback()`
`235`	`234`	`if responseFuture.Done != nil {`
`236`	`235`	`close(responseFuture.Done)`
`237`	`236`	`}`
	`237`	`+ responseFuture.executeInvokeCallback()`
`238`	`238`	`})`
`239`	`239`	`}`
`240`	`240`	`} else {`