Skip to content

Commit e577c47

Browse files
committed
Make refactoring warnings message localizable
1 parent 7c4bd1a commit e577c47

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/CodeRefactoring.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
import org.netbeans.modules.refactoring.spi.Transaction;
6262
import org.openide.filesystems.FileObject;
6363
import org.openide.util.Exceptions;
64+
import org.openide.util.NbBundle;
6465

6566
/**
6667
*
@@ -141,27 +142,32 @@ private static Problem prepare(AbstractRefactoring refactoring, RefactoringSessi
141142
return p;
142143
}
143144

145+
@NbBundle.Messages({
146+
"# {0} - problems message",
147+
"PROMPT_AskProceedWithRefactoringProblems=Refactoring may lead to following problems: {0}.\nDo you still want to proceed with the refactoring?",
148+
"PROMPT_AskProceedWithRefactoringProblems_Yes=Yes",
149+
"PROMPT_AskProceedWithRefactoringProblems_No=No",
150+
})
144151
private static ShowMessageRequestParams warningsMessageParams(
145152
Problem p) {
146-
final MessageActionItem yes = new MessageActionItem("Yes");
147-
final MessageActionItem no = new MessageActionItem("No");
153+
final MessageActionItem yes = new MessageActionItem(Bundle.PROMPT_AskProceedWithRefactoringProblems_Yes());
154+
final MessageActionItem no = new MessageActionItem(Bundle.PROMPT_AskProceedWithRefactoringProblems_No());
148155
ShowMessageRequestParams smrp = new ShowMessageRequestParams(Arrays.asList(yes, no));
149156
StringBuilder msgs = new StringBuilder();
150157
while (p != null) {
151158
msgs.append(p.getMessage());
152159
msgs.append('\n');
153160
p = p.getNext();
154161
}
155-
smrp.setMessage(String.format("Refactoring will lead to following problems \n %s ,"
156-
+ "Do you want to proceed with the problems ?", msgs.toString()));
162+
smrp.setMessage(Bundle.PROMPT_AskProceedWithRefactoringProblems(msgs.toString()));
157163
smrp.setType(MessageType.Warning);
158164
return smrp;
159165
}
160166

161167
private static void showRefactoringWarnings(NbCodeLanguageClient client,AbstractRefactoring refactoring,RefactoringSession session,Problem p) {
162168
ShowMessageRequestParams smrp = warningsMessageParams(p);
163169
client.showMessageRequest(smrp).thenAccept(ai -> {
164-
if (ai.getTitle().equalsIgnoreCase("Yes")) {
170+
if (ai.getTitle().equalsIgnoreCase(Bundle.PROMPT_AskProceedWithRefactoringProblems_Yes())) {
165171
try {
166172
client.applyEdit(new ApplyWorkspaceEditParams(perform(refactoring, session)));
167173
} catch (Exception ex) {

0 commit comments

Comments
 (0)