<filtering>true</filtering>Failure in 3.4.0

[yuedaxia76]

Affected version

3.4.0

Bug description

    <resources>
        <resource>
            <directory>src/main/java</directory>
            <filtering>true</filtering>
            <includes>
                <include>**/*.properties</include>
            </includes>
        </resource>
        <resource>
            <directory>src/main/java</directory>
            <includes>
                <include>**/*.xml</include>
                <include>**/*.js</include>
                <include>META-INF/**</include>
            </includes>
        </resource>
    </resources>

The first resource filtering not run ,but version 3.3.1 or Previous is ok.

[slawekjaranowski]

@yuedaxia76 can you provide steps, simple project which can reproduce your issue?

I have added and IT - please look at

• Add IT for #444 issue #446

and I can not reproduce it

[yuedaxia76]

testreas.zip

this is netbeans project

[pzygielo]

testreas.zip

So, it's about

loginSession.refNoCl_cache=@cacheName@

with 3.4.0 not being filtered, while with 3.3.1 being to:

loginSession.refNoCl_cache=com.gentlesoft.framework.ds.MulDsCacheImpli

Right?

[pzygielo]

Here it seems to be due to

493aa4642e11aa92724330af85785f7939688793 is the first bad commit

• 493aa46/[MRESOURCES-303] Bump org.apache.maven.shared:maven-filtering from 3.3.1 to 3.3.2 #68

I have not visited maven-filtering yet.

[pzygielo]

On maven-filtering side seems to be due to

• apache/maven-filtering@1371dcf [MSHARED-1216] Use caching output stream maven-filtering#73

[yuedaxia76]

@pzygielo YES

[slawekjaranowski]

I see you define two set of resources:

    <resources>
        <resource>
            <directory>src/main/java</directory>
            <filtering>true</filtering>
            <includes>
                <include>**/*.properties</include>
            </includes>
        </resource>
        <resource>
            <directory>src/main/java</directory>
            <includes>
                <include>**/*.xml</include>
                <include>**/*.js</include>
                <include>META-INF/**</include>
            </includes>
        </resource>
    </resources>

both set match file which you want to filter - META-INF/commons.properties

so META-INF/commons.properties is processed twice - second simply copy without filtering

In old implementation of maven-filtering only timestamp of files was checked, now content is analized so next copy override file

[yuedaxia76]

like this


src/main/java
true

/*.properties



src/main/java

/.xml
**/.js



The configuration result is correct.