chore: migrate to mojotest - PmdReportTest

sparsick · sparsick · commit 4d61e743f5c0 · 2025-11-12T16:13:57.000+01:00
Signed-off-by: Sandra Parsick &lt;sandra@parsick.dev&gt;
diff --git a/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java b/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
diff --git a/src/test/resources/unit/custom-configuration/custom-configuration-plugin-config.xml b/src/test/resources/unit/custom-configuration/custom-configuration-plugin-config.xml
@@ -43,7 +43,7 @@ under the License.
           <inputEncoding>ISO-8859-1</inputEncoding>
           <rulesets>
             <ruleset>rulesets/java/maven-pmd-plugin-default.xml</ruleset>
-            <ruleset>${basedir}/src/test/resources/unit/custom-configuration/resources/rulesets/custom.xml</ruleset>
+            <ruleset>${basedir}/resources/rulesets/custom.xml</ruleset>
           </rulesets>
           <targetJdk>1.4</targetJdk>
           <minimumPriority>4</minimumPriority>
@@ -52,7 +52,7 @@ under the License.
             <exclude>**/AnotherSample.java</exclude>
           </excludes>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/custom-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
         <dependencies>
diff --git a/src/test/resources/unit/custom-configuration/skip-plugin-config.xml b/src/test/resources/unit/custom-configuration/skip-plugin-config.xml
@@ -44,6 +44,9 @@ under the License.
           <targetJdk>1.4</targetJdk>
           <minimumPriority>4</minimumPriority>
           <skip>true</skip>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
         <dependencies>
           <dependency>
diff --git a/src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml b/src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml
@@ -42,7 +42,7 @@ under the License.
           <xrefLocation>${basedir}/target/test/unit/default-configuration/target/site/xref</xrefLocation>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
         <dependencies>
diff --git a/src/test/resources/unit/default-configuration/javascript-configuration-plugin-config.xml b/src/test/resources/unit/default-configuration/javascript-configuration-plugin-config.xml
@@ -49,7 +49,7 @@ under the License.
             <include>**/*.js</include>
           </includes>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/js</compileSourceRoot>
+            <compileSourceRoot>${basedir}/js</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
diff --git a/src/test/resources/unit/default-configuration/jsp-configuration-plugin-config.xml b/src/test/resources/unit/default-configuration/jsp-configuration-plugin-config.xml
@@ -51,7 +51,7 @@ under the License.
             <include>**/*.jsp</include>
           </includes>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/jsp</compileSourceRoot>
+            <compileSourceRoot>${basedir}/jsp</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-default-configuration-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-default-configuration-plugin-config.xml
@@ -37,6 +37,9 @@ under the License.
           <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory>
           <failOnViolation>true</failOnViolation>
           <printFailingErrors>true</printFailingErrors>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
       </plugin>
     </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml
@@ -38,6 +38,9 @@ under the License.
            <failOnViolation>true</failOnViolation>
            <failurePriority>3</failurePriority>
            <verbose>true</verbose>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
       </plugin>
     </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-failmaxviolation-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-failmaxviolation-plugin-config.xml
@@ -39,6 +39,9 @@ under the License.
                     <failurePriority>3</failurePriority>
                     <verbose>true</verbose>
                     <maxAllowedViolations>3</maxAllowedViolations>
+                    <compileSourceRoots>
+                        <compileSourceRoot>${basedir}</compileSourceRoot>
+                    </compileSourceRoots>
                 </configuration>
             </plugin>
         </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml
@@ -38,6 +38,9 @@ under the License.
           <failOnViolation>true</failOnViolation>
           <failurePriority>1</failurePriority>
           <verbose>false</verbose>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
       </plugin>
     </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-notfailmaxviolation-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-notfailmaxviolation-plugin-config.xml
@@ -39,6 +39,9 @@ under the License.
                     <failurePriority>3</failurePriority>
                     <verbose>true</verbose>
                     <maxAllowedViolations>5</maxAllowedViolations>
+                    <compileSourceRoots>
+                        <compileSourceRoot>${basedir}</compileSourceRoot>
+                    </compileSourceRoots>
                 </configuration>
             </plugin>
         </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml
@@ -37,6 +37,9 @@ under the License.
           <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory>
           <failOnViolation>false</failOnViolation>
           <verbose>false</verbose>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
       </plugin>
     </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-check-pmd-exclusions-configuration-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-check-pmd-exclusions-configuration-plugin-config.xml
@@ -40,6 +40,9 @@ under the License.
           <verbose>false</verbose>
           <printFailingErrors>true</printFailingErrors>
           <excludeFromFailureFile>${basedir}/src/test/resources/unit/excludes/pmd_exclude.properties</excludeFromFailureFile>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
       </plugin>
     </plugins>
diff --git a/src/test/resources/unit/default-configuration/pmd-report-custom-rules.xml b/src/test/resources/unit/default-configuration/pmd-report-custom-rules.xml
@@ -36,16 +36,16 @@ under the License.
           <project implementation="org.apache.maven.plugins.pmd.stubs.DefaultConfigurationMavenProjectStub"/>
           <outputDirectory>${basedir}/target/test/unit/default-configuration/target/site</outputDirectory>
           <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory>
-          <rulesetsTargetDirectory>${basedir}/target/test/unit/default-configuration/target/pmd/rulesets</rulesetsTargetDirectory>
+          <rulesetsTargetDirectory>${basedir}/target/pmd/rulesets</rulesetsTargetDirectory>
           <rulesets>
-            <ruleset>${basedir}/src/test/resources/unit/default-configuration/rulesets/custom-rules.xml</ruleset>
+            <ruleset>${basedir}/rulesets/custom-rules.xml</ruleset>
           </rulesets>
           <format>xml</format>
           <linkXRef>true</linkXRef>
-          <xrefLocation>${basedir}/target/test/unit/default-configuration/target/site/xref</xrefLocation>
+          <xrefLocation>${basedir}/target/site/xref</xrefLocation>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
diff --git a/src/test/resources/unit/default-configuration/pmd-report-include-xml-in-reports-config.xml b/src/test/resources/unit/default-configuration/pmd-report-include-xml-in-reports-config.xml
@@ -40,6 +40,9 @@ under the License.
           <format>xml</format>
           <inputEncoding>UTF-8</inputEncoding>
           <includeXmlInReports>true</includeXmlInReports>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
         <dependencies>
           <dependency>
diff --git a/src/test/resources/unit/default-configuration/pmd-report-no-render-violations-by-priority.xml b/src/test/resources/unit/default-configuration/pmd-report-no-render-violations-by-priority.xml
@@ -42,7 +42,7 @@ under the License.
           <xrefLocation>${basedir}/target/test/unit/default-configuration/target/site/xref</xrefLocation>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
           <renderViolationsByPriority>false</renderViolationsByPriority>
         </configuration>
diff --git a/src/test/resources/unit/default-configuration/pmd-report-not-render-rule-priority-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-report-not-render-rule-priority-plugin-config.xml
@@ -42,7 +42,7 @@ under the License.
           <xrefLocation>${basedir}/target/test/unit/default-configuration/target/site/xref</xrefLocation>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
           <renderRuleViolationPriority>false</renderRuleViolationPriority>
         </configuration>
diff --git a/src/test/resources/unit/default-configuration/pmd-report-pmd-exclusions-configuration-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-report-pmd-exclusions-configuration-plugin-config.xml
@@ -42,9 +42,9 @@ under the License.
           <xrefLocation>${basedir}/target/test/unit/default-configuration/target/site/xref</xrefLocation>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
-          <excludeFromFailureFile>${basedir}/src/test/resources/unit/excludes/pmd_exclude.properties</excludeFromFailureFile>
+          <excludeFromFailureFile>${basedir}/excludes/pmd_exclude.properties</excludeFromFailureFile>
         </configuration>
         <dependencies>
           <dependency>
diff --git a/src/test/resources/unit/default-configuration/pmd-report-resolve-rulesets.xml b/src/test/resources/unit/default-configuration/pmd-report-resolve-rulesets.xml
@@ -38,7 +38,7 @@ under the License.
           <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory>
           <rulesetsTargetDirectory>${basedir}/target/test/unit/default-configuration/target/pmd/rulesets</rulesetsTargetDirectory>
           <rulesets>
-            <ruleset>${basedir}/src/test/resources/unit/default-configuration/rulesets/custom-rules.xml</ruleset>
+            <ruleset>${basedir}/rulesets/custom-rules.xml</ruleset>
             <ruleset>category/java/bestpractices.xml</ruleset>
             <ruleset>category/java/design.xml</ruleset>
             <!-- note, the port of the http urls will be replaced by the unit test -->
@@ -51,7 +51,7 @@ under the License.
           <xrefLocation>${basedir}/target/test/unit/default-configuration/target/site/xref</xrefLocation>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
diff --git a/src/test/resources/unit/default-configuration/pmd-with-analysis-cache-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-with-analysis-cache-plugin-config.xml
@@ -44,7 +44,7 @@ under the License.
           <analysisCache>true</analysisCache>
           <analysisCacheLocation>${basedir}/target/test/unit/pmd-with-analysis-cache-plugin-config/target/pmd/pmd.cache</analysisCacheLocation>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
         <dependencies>
diff --git a/src/test/resources/unit/default-configuration/pmd-with-suppressMarker-no-render-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-with-suppressMarker-no-render-plugin-config.xml
@@ -44,7 +44,7 @@ under the License.
           <suppressMarker>SUPPRESSME</suppressMarker>
           <renderSuppressedViolations>false</renderSuppressedViolations>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
         <dependencies>
diff --git a/src/test/resources/unit/default-configuration/pmd-with-suppressMarker-plugin-config.xml b/src/test/resources/unit/default-configuration/pmd-with-suppressMarker-plugin-config.xml
@@ -43,7 +43,7 @@ under the License.
           <inputEncoding>UTF-8</inputEncoding>
           <suppressMarker>SUPPRESSME</suppressMarker>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/default-configuration/</compileSourceRoot>
+            <compileSourceRoot>${basedir}</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
         <dependencies>
diff --git a/src/test/resources/unit/empty-report/skip-empty-report-plugin-config.xml b/src/test/resources/unit/empty-report/skip-empty-report-plugin-config.xml
@@ -34,11 +34,11 @@ under the License.
         <artifactId>maven-pmd-plugin</artifactId>
         <configuration>
           <project implementation="org.apache.maven.plugins.pmd.stubs.CustomConfigurationMavenProjectStub"/>
-          <outputDirectory>${basedir}/target/test/unit/empty-report/target/site</outputDirectory>
-          <targetDirectory>${basedir}/target/test/unit/empty-report/target</targetDirectory>
-          <rulesetsTargetDirectory>${basedir}/target/test/unit/empty-report/target/pmd/rulesets</rulesetsTargetDirectory>
+          <outputDirectory>${basedir}/target/test/unit/skip-empty-report/target/site</outputDirectory>
+          <targetDirectory>${basedir}/target/test/unit/skip-empty-report/target</targetDirectory>
+          <rulesetsTargetDirectory>${basedir}/target/test/unit/skip-empty-report/target/pmd/rulesets</rulesetsTargetDirectory>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/empty-report/java/</compileSourceRoot>
+            <compileSourceRoot>${basedir}/java</compileSourceRoot>
           </compileSourceRoots>
           <inputEncoding>UTF-8</inputEncoding>
           <skipEmptyReport>true</skipEmptyReport>
diff --git a/src/test/resources/unit/exclude-roots/pmd-exclude-roots-plugin-config.xml b/src/test/resources/unit/exclude-roots/pmd-exclude-roots-plugin-config.xml
@@ -40,14 +40,14 @@ under the License.
           <format>xml</format>
           <inputEncoding>UTF-8</inputEncoding>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/exclude-roots/src</compileSourceRoot>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/exclude-roots/baseroot/src1</compileSourceRoot>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/exclude-roots/baseroot/src2</compileSourceRoot>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/exclude-roots/othersrc</compileSourceRoot>
+            <compileSourceRoot>${basedir}/src</compileSourceRoot>
+            <compileSourceRoot>${basedir}/baseroot/src1</compileSourceRoot>
+            <compileSourceRoot>${basedir}/baseroot/src2</compileSourceRoot>
+            <compileSourceRoot>${basedir}/othersrc</compileSourceRoot>
           </compileSourceRoots>
           <excludeRoots>
-            <excludeRoot>${basedir}/src/test/resources/unit/exclude-roots/baseroot</excludeRoot>
-            <excludeRoot>${basedir}/src/test/resources/unit/exclude-roots/othersrc</excludeRoot>
+            <excludeRoot>${basedir}/baseroot</excludeRoot>
+            <excludeRoot>${basedir}/othersrc</excludeRoot>
           </excludeRoots>
         </configuration>
         <dependencies>
diff --git a/src/test/resources/unit/invalid-format/invalid-format-plugin-config.xml b/src/test/resources/unit/invalid-format/invalid-format-plugin-config.xml
@@ -41,6 +41,9 @@ under the License.
           <linkXRef>false</linkXRef>
           <xrefLocation>${basedir}/target/test/unit/invalid-format/target/site/xref</xrefLocation>
           <inputEncoding>ISO-8859-1</inputEncoding>
+            <compileSourceRoots>
+                <compileSourceRoot>${basedir}</compileSourceRoot>
+            </compileSourceRoots>
         </configuration>
       </plugin>
     </plugins>
diff --git a/src/test/resources/unit/processing-error/pmd-processing-error-no-report-plugin-config.xml b/src/test/resources/unit/processing-error/pmd-processing-error-no-report-plugin-config.xml
@@ -42,7 +42,7 @@ under the License.
           <skipPmdError>true</skipPmdError>
           <renderProcessingErrors>false</renderProcessingErrors>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/processing-error/src</compileSourceRoot>
+            <compileSourceRoot>${basedir}/src</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
diff --git a/src/test/resources/unit/processing-error/pmd-processing-error-plugin-config.xml b/src/test/resources/unit/processing-error/pmd-processing-error-plugin-config.xml
@@ -41,7 +41,7 @@ under the License.
           <inputEncoding>UTF-8</inputEncoding>
           <skipPmdError>false</skipPmdError>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/processing-error/src</compileSourceRoot>
+            <compileSourceRoot>${basedir}/src</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
diff --git a/src/test/resources/unit/processing-error/pmd-processing-error-skip-plugin-config.xml b/src/test/resources/unit/processing-error/pmd-processing-error-skip-plugin-config.xml
@@ -41,7 +41,7 @@ under the License.
           <inputEncoding>UTF-8</inputEncoding>
           <skipPmdError>true</skipPmdError>
           <compileSourceRoots>
-            <compileSourceRoot>${basedir}/src/test/resources/unit/processing-error/src</compileSourceRoot>
+            <compileSourceRoot>${basedir}/src</compileSourceRoot>
           </compileSourceRoots>
         </configuration>
       </plugin>
