Skip to content

Commit 33e8c2b

Browse files
authored
Merge pull request #370 from apache/README-reviewing
docs: call out that we appreciate contributor reviews
2 parents 4bd8d92 + 58cbc5a commit 33e8c2b

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ This repository hosts GitHub Actions developed by the ASF community and approved
66
- [Available GitHub Actions](#available-github-actions)
77
- [Organization-wide GitHub Actions Allow List](#management-of-organization-wide-github-actions-allow-list)
88
- [Adding a New Action](#adding-a-new-action-to-the-allow-list)
9+
- [Reviewing](#reviewing)
910
- [Adding a New Version](#adding-a-new-version-to-the-allow-list)
1011
- [Manual Version Addition](#manual-addition-of-specific-versions)
1112
- [Removing a Version](#removing-a-version-manually)
@@ -25,6 +26,8 @@ To contribute a GitHub Action to this repository:
2526
- Any special considerations or limitations
2627
3. **Create a pull request** to merge your branch into the main branch
2728

29+
## Reviewing
30+
2831
The Infrastructure team will review each proposed Action based on:
2932
- Overall usefulness to the ASF community
3033
- Maintenance complexity
@@ -33,6 +36,12 @@ The Infrastructure team will review each proposed Action based on:
3336

3437
Once approved, the Infrastructure team will merge the pull request and add the new Action to the list of available Actions for all ASF projects.
3538

39+
We highly appreciate contributed reviews, especially from people
40+
associated with the projects that (would like to) use a particular
41+
action, even if they're not committers on _this_ project: you're
42+
especially qualified to judge and vouch for the safety and
43+
correctness of the action.
44+
3645
## Available GitHub Actions
3746

3847
- [ASF Infrastructure Pelican Action](/pelican/README.md): Generate and publish project websites with GitHub Actions
@@ -133,4 +142,4 @@ existing/action:
133142

134143
The infrastructure team will prioritize these removal requests and may take additional steps to notify affected projects if necessary.
135144

136-
For 'regular' removals (not security responses), you can use `./utils/action-usage.sh someorg/theaction` to see if/how an action is still used anywhere in the ASF, and create a 'regular' PR removing it from `actions.yml` when it is no longer used.
145+
For 'regular' removals (not security responses), you can use `./utils/action-usage.sh someorg/theaction` to see if/how an action is still used anywhere in the ASF, and create a 'regular' PR removing it from `actions.yml` (or adding an expiration date) when it is no longer used.

0 commit comments

Comments
 (0)