Skip to content

feat!: Support compression codecs for Avro Files (inlcuding manifest and manifest lists) #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emkornfield wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat!: Support compression codecs for Avro Files (inlcuding manifest and manifest lists) #1851

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
665b970
feat!: Support compression codecs for JSON metadata and Avro
emkornfield Nov 12, 2025
091d3bc
fmt
emkornfield Nov 13, 2025
41a8c1c
fix clippy
emkornfield Nov 13, 2025
51e781e
clippy again
emkornfield Nov 13, 2025
253bf59
wip
emkornfield Nov 16, 2025
8bdb52d
address comments
emkornfield Nov 16, 2025
9d27116
no clone needed
emkornfield Nov 16, 2025
d1ee0b2
test compression works
emkornfield Nov 16, 2025
393622f
comments
emkornfield Nov 17, 2025
46fdb8e
update tests
emkornfield Nov 17, 2025
d50cb7d
address comments
emkornfield Nov 19, 2025
5370f77
remove parse optional property
emkornfield Nov 19, 2025
6b3d8ed
fmt
emkornfield Nov 19, 2025
5ec090f
wip
emkornfield Nov 21, 2025
4337a34
address comments
emkornfield Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crates/iceberg/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ flate2 = { workspace = true }
fnv = { workspace = true }
futures = { workspace = true }
itertools = { workspace = true }
log = { workspace = true }
miniz_oxide = "0.8"
Copy link
Contributor

@liurenjie1024 liurenjie1024 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We manage dependencies version in root workspace.

moka = { version = "0.12.10", features = ["future"] }
murmur3 = { workspace = true }
num-bigint = { workspace = true }
Expand Down
7 changes: 5 additions & 2 deletions crates/iceberg/src/io/object_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,9 @@ mod tests {
use crate::TableIdent;
use crate::io::{FileIO, OutputFile};
use crate::spec::{
DataContentType, DataFileBuilder, DataFileFormat, Literal, ManifestEntry,
ManifestListWriter, ManifestStatus, ManifestWriterBuilder, Struct, TableMetadata,
CompressionSettings, DataContentType, DataFileBuilder, DataFileFormat, Literal,
ManifestEntry, ManifestListWriter, ManifestStatus, ManifestWriterBuilder, Struct,
TableMetadata,
};
use crate::table::Table;

Expand Down Expand Up @@ -275,6 +276,7 @@ mod tests {
None,
current_schema.clone(),
current_partition_spec.as_ref().clone(),
CompressionSettings::default(),
)
.build_v2_data();
writer
Expand Down Expand Up @@ -307,6 +309,7 @@ mod tests {
current_snapshot.snapshot_id(),
current_snapshot.parent_snapshot_id(),
current_snapshot.sequence_number(),
CompressionSettings::default(),
);
manifest_list_write
.add_manifests(vec![data_file_manifest].into_iter())
Expand Down
10 changes: 7 additions & 3 deletions crates/iceberg/src/scan/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,9 @@ pub mod tests {
use crate::io::{FileIO, OutputFile};
use crate::scan::FileScanTask;
use crate::spec::{
DataContentType, DataFileBuilder, DataFileFormat, Datum, Literal, ManifestEntry,
ManifestListWriter, ManifestStatus, ManifestWriterBuilder, NestedField, PartitionSpec,
PrimitiveType, Schema, Struct, StructType, TableMetadata, Type,
CompressionSettings, DataContentType, DataFileBuilder, DataFileFormat, Datum, Literal,
ManifestEntry, ManifestListWriter, ManifestStatus, ManifestWriterBuilder, NestedField,
PartitionSpec, PrimitiveType, Schema, Struct, StructType, TableMetadata, Type,
};
use crate::table::Table;

Expand Down Expand Up @@ -749,6 +749,7 @@ pub mod tests {
None,
current_schema.clone(),
current_partition_spec.as_ref().clone(),
CompressionSettings::default(),
)
.build_v2_data();
writer
Expand Down Expand Up @@ -826,6 +827,7 @@ pub mod tests {
current_snapshot.snapshot_id(),
current_snapshot.parent_snapshot_id(),
current_snapshot.sequence_number(),
CompressionSettings::default(),
);
manifest_list_write
.add_manifests(vec![data_file_manifest].into_iter())
Expand Down Expand Up @@ -961,6 +963,7 @@ pub mod tests {
None,
current_schema.clone(),
current_partition_spec.as_ref().clone(),
CompressionSettings::default(),
)
.build_v2_data();

Expand Down Expand Up @@ -1045,6 +1048,7 @@ pub mod tests {
current_snapshot.snapshot_id(),
current_snapshot.parent_snapshot_id(),
current_snapshot.sequence_number(),
CompressionSettings::default(),
);
manifest_list_write
.add_manifests(vec![data_file_manifest].into_iter())
Expand Down
Loading
Loading