-
Notifications
You must be signed in to change notification settings - Fork 253
fix: checkSparkMaybeThrows should compare Spark and Comet results in success case #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // compare results and confirm that they match | ||
| checkSparkAnswer(df) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix. All other changes are for renaming the method.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
============================================
+ Coverage 56.12% 58.64% +2.51%
- Complexity 976 1477 +501
============================================
Files 119 163 +44
Lines 11743 13990 +2247
Branches 2251 2378 +127
============================================
+ Hits 6591 8204 +1613
- Misses 4012 4578 +566
- Partials 1140 1208 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parthchandra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I am looking into this failure: |
Which issue does this PR close?
Closes #2657
Rationale for this change
What changes are included in this PR?
checkSparkAnswerin success casecheckSparkAnswermethodsHow are these changes tested?
Existing tests