Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Nov 7, 2025

Which issue does this PR close?

Closes #2657

Rationale for this change

What changes are included in this PR?

  • Delegate to checkSparkAnswer in success case
  • Rename method for consistency with other checkSparkAnswer methods

How are these changes tested?

Existing tests

Comment on lines +319 to +320
// compare results and confirm that they match
checkSparkAnswer(df)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix. All other changes are for renaming the method.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.64%. Comparing base (f09f8af) to head (8c4d13b).
⚠️ Report is 686 commits behind head on main.

Files with missing lines Patch % Lines
...scala/org/apache/comet/expressions/CometCast.scala 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2728      +/-   ##
============================================
+ Coverage     56.12%   58.64%   +2.51%     
- Complexity      976     1477     +501     
============================================
  Files           119      163      +44     
  Lines         11743    13990    +2247     
  Branches       2251     2378     +127     
============================================
+ Hits           6591     8204    +1613     
- Misses         4012     4578     +566     
- Partials       1140     1208      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andygrove
Copy link
Member Author

I am looking into this failure:

2025-11-07T16:55:12.8149030Z - cast ArrayType to StringType *** FAILED *** (23 seconds, 552 milliseconds)
2025-11-07T16:55:12.8293960Z   Results do not match for query:

@andygrove andygrove merged commit e77998a into apache:main Nov 11, 2025
102 checks passed
@andygrove andygrove deleted the checkSparkMaybeThrows branch November 11, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checkSparkMaybeThrows does not check for correct results in success case

3 participants