Merge pull request #279 from anzharip/dev

build: bump busboy and @types/busboy

Author: anzharip

.github/workflows/build-and-test-dev.yml

@@ -0,0 +1,35 @@
+name: Node.js Build & Test
+
+on:
+  push:
+    branches: [dev]
+  pull_request:
+    branches: [dev]
+
+jobs:
+  build-and-test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [14.x, 16.x, 17.x ]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - run: npm ci
+      - run: npm run build --if-present
+      - run: npm run test:cov
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v1
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          directory: ./coverage/
+          flags: unittests
+          name: codecov-umbrella
+          fail_ci_if_error: true
+          path_to_write_report: ./coverage/codecov_report.txt
+          verbose: true

.github/workflows/build-and-test.yml

@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 15.x]
+        node-version: [14.x, 16.x, 17.x ]
 
     steps:
       - uses: actions/checkout@v2

package-lock.json

@@ -53,8 +53,8 @@
   },
   "dependencies": {
     "@azure/functions": "^3.0.0",
-    "@types/busboy": "^0.3.1",
+    "@types/busboy": "^1.3.0",
     "@types/node": "^17.0.0",
-    "busboy": "^0.3.1"
+    "busboy": "^1.4.0"
   }
 }

package.json

@@ -4,6 +4,7 @@ import { ParsedField } from "./types/parsed-field.type";
 import { ParsedFile } from "./types/parsed-file.type";
 import { ParsedMultipartFormData } from "./types/parsed-multipart-form-data.type";
 import { Config } from "./types/config.type";
+import { IncomingHttpHeaders } from "http";
 
 export default async function parseMultipartFormData(
   request: HttpRequest,
@@ -16,34 +17,34 @@ export default async function parseMultipartFormData(
 
       let busboy;
       if (options) {
-        busboy = new Busboy({
-          headers: (request.headers as unknown) as Busboy.BusboyHeaders,
+        busboy = Busboy({
+          headers: (request.headers as unknown) as IncomingHttpHeaders,
           ...options,
         });
       } else {
-        busboy = new Busboy({
-          headers: (request.headers as unknown) as Busboy.BusboyHeaders,
+        busboy = Busboy({
+          headers: (request.headers as unknown) as IncomingHttpHeaders,
         });
       }
 
       busboy.on(
         "file",
-        function (fieldname, file, filename, encoding, mimetype) {
+        function (name, stream, { filename, encoding, mimeType }) {
           const arrayBuffer: Buffer[] = [];
-          file.on("data", function (data) {
+          stream.on("data", function (data) {
             arrayBuffer.push(data);
           });
 
-          file.on("end", function () {
+          stream.on("end", function () {
             const bufferFile = Buffer.concat(arrayBuffer);
             files.push(
               new Promise((resolve) => {
                 resolve({
-                  fieldname,
+                  name,
                   bufferFile,
                   filename,
                   encoding,
-                  mimetype,
+                  mimeType,
                 });
               })
             );
@@ -54,22 +55,19 @@ export default async function parseMultipartFormData(
       busboy.on(
         "field",
         function (
-          fieldname,
+          name,
           value,
-          fieldnameTruncated,
-          valueTruncated,
-          encoding,
-          mimetype
+          { nameTruncated, valueTruncated, encoding, mimeType }
         ) {
           fields.push(
             new Promise((resolve) => {
               resolve({
-                fieldname,
+                name,
                 value,
-                fieldnameTruncated,
+                nameTruncated,
                 valueTruncated,
                 encoding,
-                mimetype,
+                mimeType,
               });
             })
           );

src/index.ts

@@ -1,8 +1,8 @@
 export type ParsedField = {
-  fieldname: string;
+  name: string;
   value: any;
-  fieldnameTruncated: boolean;
+  nameTruncated: boolean;
   valueTruncated: boolean;
   encoding: string;
-  mimetype: string;
+  mimeType: string;
 };

src/types/parsed-field.type.ts

@@ -1,7 +1,7 @@
 export type ParsedFile = {
-  fieldname: string;
+  name: string;
   bufferFile: Buffer;
   filename: string;
   encoding: string;
-  mimetype: string;
+  mimeType: string;
 };