Revisit parameter validation

* Remove calls to deprecated validate_* functions
  Replace regex validation with !~ comparison
* Remove string/bool/hash/array validations
  Not truly relevant anyway
  "Puppet 3 deprecation is coming"

Author: antoineco

manifests/init.pp

@@ -75,11 +75,15 @@
   }
 
   # parameters validation
-  validate_re($version, '^([0-9]|[0-9]u[0-9]{1,3})$', '$version must be formated as \'major\'u\'minor\' or just \'major\'')
-  validate_re($type, '^(jre|jdk)$', '$type must be either \'jre\' or \'jdk\'')
-  validate_re($format_real, '^(rpm|tar\.gz)$', '$format must be either \'rpm\' or \'tar.gz\'')
-  validate_bool($check_checksum, $add_alternative)
-  validate_absolute_path($install_path)
+  if $version !~ /^([0-9]|[0-9]u[0-9]{1,3})$/ {
+    fail('$version must be formated as \'major\'u\'minor\' or just \'major\'')
+  }
+  if $type !~ /^(jre|jdk)$/ {
+    fail('$type must be either \'jre\' or \'jdk\'')
+  }
+  if $format_real !~ /^(rpm|tar\.gz)$/ {
+    fail('$format must be either \'rpm\' or \'tar.gz\'')
+  }
 
   # set to latest release if no minor version was provided
   if $version == '8' {

manifests/installation.pp

@@ -56,9 +56,12 @@
   $install_path = $oracle_java::install_path
 
   # parameters validation
-  validate_re($version, '^([0-9]|[0-9]u[0-9]{1,3})$', '$version must be formated as \'major\'u\'minor\' or just \'major\'')
-  validate_re($type, '^(jre|jdk)$', '$type must be either \'jre\' or \'jdk\'')
-  validate_bool($check_checksum, $add_alternative)
+  if $version !~ /^([0-9]|[0-9]u[0-9]{1,3})$/ {
+    fail('$version must be formated as \'major\'u\'minor\' or just \'major\'')
+  }
+  if $type !~ /^(jre|jdk)$/ {
+    fail('$type must be either \'jre\' or \'jdk\'')
+  }
 
   # set to latest release if no minor version was provided
   if $version == '8' {