postgresql_db: add session_role support for raw connections #865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #864
Fixes
postgresql_db"session_role" behavior when state isdump/restorefor binary (.pgc) archives.It was being ignored but now it behaves as intended by pg_dump/pg_restore
ISSUE TYPE
COMPONENT NAME
postgresql_db
ADDITIONAL INFORMATION
When pg_dump is used, the
--roleparameter is used to switch to a different user/role that has sufficient permissions to perform the dump.When pg_restore is used, the
--roleparameter, in combination with--no-owner, allows you to restore the objects contained in the archive under new ownership (the one specified with--role).Up to now, whenever pg_dump/pg_restore was used, the
session_roleparameter was being ignored and it would give surprising results (or errors).Now the
session_rolebelow will be relayed as the--roleparameter for pg_dump/pg_restore.I chose to create a new test python module for this feature, as it seemed cleaner and less intrusive with regards to the current integration tests.