Comma delimited user/database string passed to postgresql_pg_hba doesn't create only 1 entry

[jedthe3rd]

SUMMARY

When using a comma delimited string of users or databases, the module creates separate line entries for each entry in the list instead of creating one entry with the list of users or databases.

ISSUE TYPE

• Bug Report

COMPONENT NAME

postgresql_pg_hba

ANSIBLE VERSION

2.16.13

COLLECTION VERSION

4.1.0

CONFIGURATION

CALLBACKS_ENABLED(/workdir/ansible.cfg) = ['ansible.posix.profile_tasks', 'ansible.posix.timer']

CONFIG_FILE() = /workdir/ansible.cfg

DEFAULT_FORKS(/workdir/ansible.cfg) = 5

DEFAULT_GATHERING(/workdir/ansible.cfg) = explicit

DEFAULT_ROLES_PATH(/workdir/ansible.cfg) = ['/roles']

DISPLAY_SKIPPED_HOSTS(/workdir/ansible.cfg) = True

GALAXY_SERVER_LIST(env: ANSIBLE_GALAXY_SERVER_LIST) = ['community', 'rhcertified']

HOST_KEY_CHECKING(/workdir/ansible.cfg) = False

PAGER(env: PAGER) = less

PERSISTENT_COMMAND_TIMEOUT(/workdir/ansible.cfg) = 60

OS / ENVIRONMENT

STEPS TO REPRODUCE

- name: "Grant access for infrastructure users"

  become: true

  community.postgresql.postgresql_pg_hba:

    dest: "/psql/data/pg_hba.conf"

    contype: "host"

    databases: "all"

    users: test1,test2,test3,test4

    address: "192.168.8.0/20"

    method: "md5"

    create: false

EXPECTED RESULTS

When specifying a CSV of users or databases it creates one pg_hba entry.

Expected pg_hba entry created:

host    all     test1,test2,test3,test4     192.168.8.0/20  md5

ACTUAL RESULTS

pg_hba entries created:

host    all     test1     192.168.8.0/20  md5

host    all     test2     192.168.8.0/20  md5

host    all     test3     192.168.8.0/20  md5

host    all     test4     192.168.8.0/20  md5

[toydarian]

This is known behavior and on my list of things to change. I haven't had a lot of time during the summer, but I hope to get to change this soon.

[toydarian]

@Andersson007 this will change the hg_hba.conf quite significantly. I think we should plan this for 5.0.0. Thoughts?

[andreasscherbaum]

This change is not backwards compatible: once the output is changed to a comma-separated list, are the old lines removed as well?

[toydarian]

This change is not backwards compatible: once the output is changed to a comma-separated list, are the old lines removed as well?

I hadn't planned to sanitize rules, as in check if one is completely included in another one. So as long as the module is not set to completely manage the file, the old rules would stay in the file and the new one (with the comma-separated list) would be added additionally.
It wouldn't break anything (the pg_hba.conf would still work), but I think we should consider this a breaking change.