fix(material/timepicker): valueChanges emitting on init #32434
+57
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the `valueChanges` stream from reactive forms was emitting on init for the timepicker input. It was because we had an `effect` that was meant to trigger `min`/`max` revalidation. I also ended up consolidating all the validation updates into a single effect so we don't have multiple sources of changes. Fixes angular#32423.
crisbeto
requested review from
mmalerba and
ok7sai
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
valueChangesstream from reactive forms was emitting on init for the timepicker input. It was because we had aneffectthat was meant to triggermin/maxrevalidation.I also ended up consolidating all the validation updates into a single effect so we don't have multiple sources of changes.
Fixes #32423.