Skip to content

Commit 21f1b31

Browse files
authored
build: only include adev_assets in snapshot builds (#32470)
This change ensures that `adev_assets` are only included in the release output when the build is configured with `snapshot-build`. This prevents these assets from being included in standard NPM releases.
1 parent 67f213a commit 21f1b31

File tree

4 files changed

+22
-10
lines changed

4 files changed

+22
-10
lines changed

.bazelrc

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,7 @@ build:release --stamp
6363

6464
build:snapshot-build --workspace_status_command="pnpm -s ng-dev:stamp --mode=snapshot"
6565
build:snapshot-build --stamp
66-
67-
##################################
68-
# Always enable Ivy compilation #
69-
##################################
70-
build --define=angular_ivy_enabled=True
66+
build:snapshot-build --//:enable_snapshot_adev_assets
7167

7268
################################
7369
# Remote Execution Setup #

BUILD.bazel

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
12
load("@devinfra//bazel/validation:defs.bzl", "validate_ts_version_matching")
23
load("@npm//:defs.bzl", "npm_link_all_packages")
34
load("//:pkg-externals.bzl", "PKG_EXTERNALS")
@@ -43,3 +44,15 @@ validate_ts_version_matching(
4344
module_lock_file = "MODULE.bazel.lock",
4445
package_json = "package.json",
4546
)
47+
48+
bool_flag(
49+
name = "enable_snapshot_adev_assets",
50+
build_setting_default = False,
51+
)
52+
53+
config_setting(
54+
name = "snapshot_adev_assets",
55+
flag_values = {
56+
":enable_snapshot_adev_assets": "true",
57+
},
58+
)

src/aria/BUILD.bazel

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ ng_package(
2020
name = "npm_package",
2121
package_name = "@angular/aria",
2222
srcs = ["package.json"],
23-
nested_packages = [
24-
":adev_assets",
25-
],
23+
nested_packages = select({
24+
"//:snapshot_adev_assets": [":adev_assets"],
25+
"//conditions:default": [],
26+
}),
2627
package_deps = [
2728
":node_modules/@angular/cdk",
2829
],

src/cdk/BUILD.bazel

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,10 @@ ng_package(
6060
] + prebuiltStyleTargets + CDK_SCSS_LIBS,
6161
nested_packages = [
6262
"//src/cdk/schematics:npm_package",
63-
":adev_assets",
64-
],
63+
] + select({
64+
"//:snapshot_adev_assets": [":adev_assets"],
65+
"//conditions:default": [],
66+
}),
6567
replace_prefixes = {
6668
"adev_assets/": "_adev_assets/",
6769
},

0 commit comments

Comments
 (0)