2022.08.09:

* fixed: bash/cache/accum-content.sh: missed to process forwarding backslash from the `md5sum` utility
* changed: bash: support `TEMP_DIR` to be declared externally

Author: andry81

bash/board/accum-stats.sh

@@ -59,9 +59,13 @@ jq_fix_null \
 [[ -z "$last_replies" || -n "${last_replies//[0-9]/}" ]] && last_replies=0
 [[ -z "$last_views" || -n "${last_views//[0-9]/}" ]] && last_views=0
 
-TEMP_DIR="$(mktemp -d)"
+if [[ -z "$TEMP_DIR" ]]; then # otherwise use exterenal TEMP_DIR
+  TEMP_DIR="$(mktemp -d)"
 
-tkl_push_trap 'curl_print_response_if_error "$TEMP_DIR/response.txt"; rm -rf "$TEMP_DIR"' EXIT
+  tkl_push_trap 'rm -rf "$TEMP_DIR"' EXIT
+fi
+
+tkl_push_trap 'curl_print_response_if_error "$TEMP_DIR/response.txt"' EXIT
 
 # CAUTION:
 #   The `sed` has to be used to ignore blank lines by replacing `CR` by `LF`.

bash/cache/accum-content.sh

@@ -168,9 +168,15 @@ fi
 
 content_index_file_prev_md5_hash=( $(md5sum -b "$content_index_file") )
 
-TEMP_DIR="$(mktemp -d)"
+# drop forwarding backslash: https://unix.stackexchange.com/questions/424628/md5sum-prepends-to-the-checksum
+#
+content_index_file_prev_md5_hash="${content_index_file_prev_md5_hash#\\}"
+
+if [[ -z "$TEMP_DIR" ]]; then # otherwise use exterenal TEMP_DIR
+  TEMP_DIR="$(mktemp -d)"
 
-tkl_push_trap 'rm -rf "$TEMP_DIR"' EXIT
+  tkl_push_trap 'rm -rf "$TEMP_DIR"' EXIT
+fi
 
 stats_failed_inc=0
 stats_skipped_inc=0
@@ -292,6 +298,10 @@ for i in $("${YQ_CMDLINE_READ[@]}" '."content-config".entries[0].dirs|keys|.[]'
     if (( is_index_file_prev_exist )); then
       # to update the file hash in the index file
       index_file_next_md5_hash=( $(md5sum -b "$index_dir/$index_file") )
+
+      # drop forwarding backslash: https://unix.stackexchange.com/questions/424628/md5sum-prepends-to-the-checksum
+      #
+      index_file_next_md5_hash="${index_file_next_md5_hash#\\}"
     fi
 
     if (( ! is_file_expired )); then
@@ -393,6 +403,10 @@ for i in $("${YQ_CMDLINE_READ[@]}" '."content-config".entries[0].dirs|keys|.[]'
 
     index_file_next_md5_hash=( $(md5sum -b "$TEMP_DIR/content/$index_dir/$index_file") )
 
+    # drop forwarding backslash: https://unix.stackexchange.com/questions/424628/md5sum-prepends-to-the-checksum
+    #
+    index_file_next_md5_hash="${index_file_next_md5_hash#\\}"
+
     if [[ "$index_file_next_md5_hash" != "$index_file_prev_md5_hash" ]]; then
       echo "File MD5 hash is changed: new=\`$index_file_next_md5_hash\` prev=\`$index_file_prev_md5_hash\`"
     else
@@ -441,6 +455,10 @@ done
 
 content_index_file_next_md5_hash=( $(md5sum -b "$content_index_file") )
 
+# drop forwarding backslash: https://unix.stackexchange.com/questions/424628/md5sum-prepends-to-the-checksum
+#
+content_index_file_next_md5_hash="${content_index_file_next_md5_hash#\\}"
+
 if (( stats_changed_inc )) || [[ "$content_index_file_next_md5_hash" != "$content_index_file_prev_md5_hash" ]]; then
   {
     # update index file change timestamp

bash/github/init-curl-workflow.sh

@@ -16,9 +16,17 @@ SOURCE_GHWF_INIT_CURL_WORKFLOW_SH=1 # including guard
 
 source "$GH_WORKFLOW_ROOT/_externals/tacklelib/bash/tacklelib/bash_tacklelib" || exit $?
 
+tkl_include_or_abort "$GH_WORKFLOW_ROOT/bash/github/init-basic-workflow.sh"
+
 
 function curl_print_response_if_error()
 {
+  if [[ -z "$TEMP_DIR" ]]; then # otherwise use exterenal TEMP_DIR
+    TEMP_DIR="$(mktemp -d)"
+
+    tkl_push_trap 'rm -rf "$TEMP_DIR"' RETURN
+  fi
+
   local last_error=$?
   local response_file="${1:-"$TEMP_DIR/response.txt"}"
 

bash/inpage/accum-downloads.sh

@@ -49,9 +49,13 @@ IFS=$'\n' read -r -d '' last_downloads <<< "$(jq -c -r ".downloads" $stats_json)
 jq_fix_null \
   last_downloads:0
 
-TEMP_DIR="$(mktemp -d)"
+if [[ -z "$TEMP_DIR" ]]; then # otherwise use exterenal TEMP_DIR
+  TEMP_DIR="$(mktemp -d)"
 
-tkl_push_trap 'curl_print_response_if_error "$TEMP_DIR/response.txt"; rm -rf "$TEMP_DIR"' EXIT
+  tkl_push_trap 'rm -rf "$TEMP_DIR"' EXIT
+fi
+
+tkl_push_trap 'curl_print_response_if_error "$TEMP_DIR/response.txt"' EXIT
 
 # CAUTION:
 #   The `sed` has to be used to ignore blank lines by replacing `CR` by `LF`.

changelog.txt

@@ -1,3 +1,7 @@
+2022.08.09:
+* fixed: bash/cache/accum-content.sh: missed to process forwarding backslash from the `md5sum` utility
+* changed: bash: support `TEMP_DIR` to be declared externally
+
 2022.08.08:
 * fixed: bash/github/init-yq-workflow.sh: `yq_restore_edited_uniform_diff` inaccurate blank lines position