✨ Use service locator for AggregateControllerQueryProviderFactory instead of global DI container

Author: andrew-demb

src/DependencyInjection/GraphQLiteCompilerPass.php

@@ -17,6 +17,7 @@
 use Symfony\Component\Cache\Adapter\ApcuAdapter;
 use Symfony\Component\Cache\Adapter\PhpFilesAdapter;
 use Symfony\Component\Cache\Psr16Cache;
+use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
@@ -297,12 +298,21 @@ public function process(ContainerBuilder $container): void
     private function registerController(string $controllerClassName, ContainerBuilder $container): void
     {
         $aggregateQueryProvider = $container->findDefinition(AggregateControllerQueryProviderFactory::class);
+
         $controllersList = $aggregateQueryProvider->getArgument(0);
         if (!is_array($controllersList)){
             throw new GraphQLException(sprintf('Expecting array in %s, arg #1', AggregateControllerQueryProviderFactory::class));
         }
+
         $controllersList[] = $controllerClassName;
         $aggregateQueryProvider->setArgument(0, $controllersList);
+
+        $serviceLocatorMap = [];
+        foreach ($controllersList as $controller) {
+            $serviceLocatorMap[$controller] = new Reference($controller);
+        }
+
+        $aggregateQueryProvider->setArgument(1, new ServiceLocatorArgument($serviceLocatorMap));
     }
 
     /**

src/Resources/config/container/graphqlite.xml

@@ -26,10 +26,13 @@
         </service>
 
         <service id="TheCodingMachine\GraphQLite\AggregateControllerQueryProviderFactory">
+            <!-- Controller classes list will be generated by compiler pass -->
             <argument type="collection">
             </argument>
-            <argument type="service" id="service_container">
+            <!-- Service locator will be generated by compiler pass -->
+            <argument type="service_locator">
             </argument>
+
             <tag name="graphql.queryprovider_factory" />
         </service>