testbenches/ip/spi_engine: Upgrade spi_engine testbench for SDO extension #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
IstvanZsSzekely
requested changes
Aug 8, 2025
Collaborator
IstvanZsSzekely
left a comment
IstvanZsSzekely
left a comment
There was a problem hiding this comment.
Initial review.
The projects that have updated documentation: AD463x, AD738x, AD7606 have broken testbenches. It seems that the HDL block design is out of date.
LBFFilho
reviewed
Aug 8, 2025
Comment on lines
+7
to
+8
| set ad_project_params(NUM_OF_SDI) 4 | ||
| set ad_project_params(NUM_OF_SDO) 4 |
Contributor
There was a problem hiding this comment.
Perhaps some of the cfgs could have different NUM_OF_SDI/NUM_OF_SDO (all are currently 4)
LBFFilho
reviewed
Aug 8, 2025
Comment on lines
+42
to
+43
| parameter NUM_OF_SDI = 1, | ||
| parameter NUM_OF_SDO = 1, |
Contributor
There was a problem hiding this comment.
Consider renaming these to NUM_OF_MISO/MOSI (or something in this vein), since the VIP could have MOSI as input or output depending on the mode in the future.
LBFFilho
reviewed
Aug 8, 2025
IstvanZsSzekely
requested changes
Sep 5, 2025
Collaborator
IstvanZsSzekely
left a comment
IstvanZsSzekely
left a comment
There was a problem hiding this comment.
Triggered another CI run to check the current status of the PR with the changes from HDL and TB PRs. The AD463x, AD7606x, AD7616 (parallel mode) projects have build issues in the testbenches, while AD57xx has issues when compiling the simulation files.
Several changes to support n lanes on the vip From Vivado 2024.2 and on, it is required a type for mailbox. This commit defines an int for the type of mailbox. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
* Update to support n lanes for the SDI and SDO; * Insert SDI lane mask instruction; * Insert SDO lane mask instruction; Signed-off-by: Carlos Souza <carlos.souza@analog.com>
* Update major version; * Update NUM_OF_SDI parameter to NUM_OF_SDIO. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Several changes to support more than one lane for SDI and SDO: * Update config files. All config files have 4 lanes now; * Insert a new test for lane mask. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Updated from NUM_OF_SDI to NUM_OF_SDIO parameter in the documentation of the following projects: * ad463x; * ad738x; * ad7606; * pulsar_adc. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Testbench was updated to use the new features related to the spi lane mask. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
offload can accept different lane masks for testing. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
This commit fixes the read and write test for the offload mode of the test_lanes. The DDR read was removed by accident in latest commit. It also fixes the mask and the num of active lanes. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Both tests were not generic regarding the sdi_lane_mask. They were relying on the default value, which is not guaranteed that it is going to enable all lanes. Added instructions to change the sdi_lane_mask before executing the tests for the FIFO and Offload modes. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Update the version of the spi engine to 2.0 since it is not backwards compatible. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
All configurations files were updated to include the SPI VIP. New variables were included to reflect the delays according to the mode of operation. The TB was also updated to use the SPI VIP API. TODO: FIFO operations are being inserted into the DMA even though it is not enabled. Need to find the cause for this bug. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Collaborator
|
Please rebase the branch on the current main to solve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes spi_vip and spi_engine driver so it can support the new testbench for the SPI Engine. Several tasks and functions were changed due to this modification.
This modification requires this spi engine version: analogdevicesinc/hdl#1808
PR Type
PR Checklist