rpc: add support for wiring.Component
#1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not infer the ports from the publicly accessible wires, but instead delegate finding the ports to the `rtlil.convert` function
whitequark
approved these changes
Oct 7, 2024
Member
whitequark
left a comment
whitequark
left a comment
There was a problem hiding this comment.
LGTM. Have you been using the RPC functionality?
Contributor
Author
|
Yeah I started using it for my current project, that requires a (system)verilog toplevel and also uses other preexisting non-amaranth modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not infer the ports from the publicly accessible wires, but instead delegate finding the ports to the
rtlil.convertfunction