Recursive manifest includes use the wrong base path

[magnusbaeck]

When the manifest contains recursive inclusions,

default.xml -> foo/bar.xml -> foo/base.xml

the original Repo code uses the directory of the top-level file (default.xml) when resolving the path of the included file, i.e. the inclusion filenames would be according to the example above. This is pretty clear when reading the _ParseManifestXml source code and its include_root parameter.

The code in this module instead joins the directory of the current file with the name from the include element, i.e. in the example above it would incorrectly attempt to open foo/foo/base.xml.

git-repo-go/manifest/manifest.go

Line 619 in 8d46bab

f, err := path.AbsJoin(filepath.Dir(file), i.Name)